Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ios notif: Control the showing of notifications #1265

Open
gnprice opened this issue Jan 8, 2025 · 0 comments
Open

ios notif: Control the showing of notifications #1265

gnprice opened this issue Jan 8, 2025 · 0 comments
Labels
a-iOS Issues specific to iOS, or requiring iOS-specific work a-notifications

Comments

@gnprice
Copy link
Member

gnprice commented Jan 8, 2025

When a notification-message comes in from the server on iOS, we should have some of our own Dart code run, and have that code control the notification that gets shown in the UI.

That's something we already do on Android: see NotificationDisplayManager. Most of the code of that class is specific to Android's notification API, so some refactoring and/or renaming will be needed.

For this issue, there doesn't need to be any change to how the notifications look or behave. If the notifications appear exactly the same way they did before, that's success.

One immediate way we can make use of having this control is to do the equivalent of #1264: check if the account is still logged in, and if not then suppress the notification.

Related issues

@gnprice gnprice added a-iOS Issues specific to iOS, or requiring iOS-specific work a-notifications labels Jan 8, 2025
@gnprice gnprice added this to the M6: Post-launch milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-iOS Issues specific to iOS, or requiring iOS-specific work a-notifications
Projects
Status: No status
Development

No branches or pull requests

1 participant