Skip to content

Add fee asset ID and native account ID to the NoteConsumptionChecker #3888

Description

@Fumuran

Currently NoteConsumptionChecker has two flaws which could be improved:

  1. We can not check that the sponsorship note carries the correct asset, i.e. the asset which is set as a fee asset in the network account against which the transaction is executed. We should provide the fee asset ID to the NoteConsumptionChecker in order to assert that the ID of the fee asset in the sponsorship note matches the fee asset of the network account.
  2. If a sponsorship note is placed in the bundle alone, the only valid option of consuming it is by reclaiming it. We should provide a native account ID to the NoteConsumptionChecker to check that the reclaimer ID equals to the native account ID.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

feesRelated to fees.standardsRelated to standard note scripts or account components

Fields

Priority

None yet

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions