fix(rust-client): apply expiration_delta to requests without own output notes - #2580
Merged
igamigo merged 1 commit intoSep 22, 2026
Merged
Conversation
Bruce039
force-pushed
the
fix-expiration-delta-without-output-notes
branch
from
September 18, 2026 22:31
4cbd47a to
1f4ff27
Compare
Bruce039
force-pushed
the
fix-expiration-delta-without-output-notes
branch
from
September 22, 2026 11:44
2edbf8c to
a319655
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2579.
TransactionRequestBuilder::expiration_deltawas only applied through theSendNotestransaction script. A request without own output notes (consume, pswap cancel, barebuild()) accepted the delta and then ran without a script, so the transaction never expired (expiration_block_num() == u32::MAX).Changes
TransactionRequest::build_transaction_script: when there is no script template and a non-zero expiration delta is set, return the standardExpirationTransactionScripttogether with itstx_script_args(), so the kernel enforces the delta.expiration_delta_without_script_template_builds_expiration_scriptand mock-chain testexpiration_delta_applies_to_request_without_own_output_notes, which fails onnextwithleft: BlockNumber(4294967295) right: BlockNumber(13).cargo nextest run -p miden-client --lib: 187 passed;miden-client-unit-tests: 143 passed; clippy clean.