Skip to content

buildNetworkNote is declared in the types but exported from no entry point #388

Description

@WiktorStarczewski

buildNetworkNote is declared in the shipped types and implemented in JS, but exported from neither entry point, so no consumer can import it.

Symptom
import { buildNetworkNote } from "@miden-sdk/miden-sdk" fails to link, while tsc accepts it: api-types.d.ts declares export declare function buildNetworkNote(opts: NetworkNoteOptions): Note and dist/*/index.d.ts ships that declaration.

Where it stands

  • Implemented at crates/web-client/js/standalone.js:121.
  • Not re-exported by crates/web-client/js/index.js (browser/lazy) or crates/web-client/js/node-index.js (the "node" condition).
  • Nothing in the repo imports it, so it has never worked rather than regressing.

Expected
Either export it from both entries, or drop the declaration if network notes are meant to be built another way (transactions already exposes the network-note paths).

Note
crates/web-client/js/__tests__/entry-parity.test.js gates the related failure (a helper exported from one entry but not the other, which is what the shared .d.ts makes a runtime break). It deliberately skips the exported-from-neither case, which is this issue; the skip references this number.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    Priority

    None yet

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions