Address review feedback from adapter review

92lleo · Nov 20, 2022 · dbf415d · dbf415d
1 parent 189bb28
commit dbf415d
Show file tree

Hide file tree

Showing 5 changed files with 6,040 additions and 809 deletions.
diff --git a/.github/workflows/test-and-release.yml b/.github/workflows/test-and-release.yml
@@ -19,7 +19,7 @@ jobs:
 
         strategy:
             matrix:
-                node-version: [12.x]
+                node-version: [16.x]
 
         steps:
             - uses: actions/checkout@v1
@@ -43,12 +43,8 @@ jobs:
         runs-on: ${{ matrix.os }}
         strategy:
             matrix:
-                node-version: [8.x, 10.x, 12.x]
+                node-version: [14.x, 16.x, 18.x]
                 os: [ubuntu-latest, windows-latest, macos-latest]
-                exclude:
-                    # Don't test Node.js 8 on Windows. npm is weird here
-                    - os: windows-latest
-                      node-version: 8.x
         steps:
             - uses: actions/checkout@v1
             - name: Use Node.js ${{ matrix.node-version }}
@@ -70,7 +66,7 @@ jobs:
               if: startsWith(runner.OS, 'windows')
               run: set DEBUG=testing:* & npm run test:integration
 
-# TODO: To enable automatic npm releases, create a token on npmjs.org 
+# TODO: To enable automatic npm releases, create a token on npmjs.org
 # Enter this token as a GitHub secret (with name NPM_TOKEN) in the repository options
 # Then uncomment the following block:
 
@@ -88,7 +84,7 @@ jobs:
 #        runs-on: ubuntu-latest
 #        strategy:
 #            matrix:
-#                node-version: [12.x]
+#                node-version: [16.x]
 #
 #        steps:
 #            - uses: actions/checkout@v1

diff --git a/io-package.json b/io-package.json
@@ -1,91 +1,91 @@
-{
-    "common": {
-        "name": "solaredge",
-        "version": "0.2.0",
-        "news": {
-            "0.2.0": {
-                "en": "Fix updating already created states and internal polishing"
-            },
-            "0.1.1": {
-                "en": "fix \"object data is invalid\" issue, now works with new js-controller"
-            },
-            "0.1.0": {
-                "en": "First beta release",
-                "de": "Erste Beta"
-            },
-            "0.0.1": {
-                "en": "initial release",
-                "de": "Erstveröffentlichung",
-                "ru": "Начальная версия",
-                "pt": "lançamento inicial",
-                "nl": "Eerste uitgave",
-                "fr": "Première version",
-                "it": "Versione iniziale",
-                "es": "Versión inicial",
-                "pl": "Pierwsze wydanie",
-                "zh-cn": "首次出版"
-            }
-        },
-        "title": "Solaredge Monitoring",
-        "titleLang": {
-            "en": "Solaredge Monitoring",
-            "de": "Solaredge-Überwachung",
-            "ru": "Мониторинг Solaredge",
-            "pt": "Solaredge Monitoring",
-            "nl": "Solaredge Monitoring",
-            "fr": "Surveillance de Solaredge",
-            "it": "Monitoraggio di Solaredge",
-            "es": "Monitoreo Solaredge",
-            "pl": "Monitorowanie Solaredge",
-            "zh-cn": "Solaredge监控"
-        },
-        "desc": {
-            "en": "Get data from solaredge monitoring portal",
-            "de": "Rufen Sie Daten vom Solaredge-Überwachungsportal ab",
-            "ru": "Получить данные с портала мониторинга Solaredge",
-            "pt": "Obter dados do portal de monitoramento solaredge",
-            "nl": "Gegevens ophalen uit de portal voor solaredge-monitoring",
-            "fr": "Obtenez les données du portail de surveillance Solaredge",
-            "it": "Ottieni dati dal portale di monitoraggio di Solaredge",
-            "es": "Obtenga datos del portal de monitoreo de solaredge",
-            "pl": "Uzyskaj dane z portalu monitorowania Solaredge",
-            "zh-cn": "从solaredge监控门户获取数据"
-        },
-        "authors": [
-            "92lleo <[email protected]>"
-        ],
-        "keywords": [
-            "solaredge",
-            "energy",
-            "power",
-            "api",
-            "monitoring"
-        ],
-        "license": "MIT",
-        "platform": "Javascript/Node.js",
-        "main": "main.js",
-        "icon": "solaredge.png",
-        "enabled": true,
-        "extIcon": "https://raw.githubusercontent.com/92lleo/ioBroker.solaredge/master/admin/solaredge.png",
-        "readme": "https://github.com/92lleo/ioBroker.solaredge/blob/master/README.md",
-        "loglevel": "info",
-        "mode": "schedule",
-        "schedule": "*/15 * * * *",
-        "type": "energy",
-        "compact": true,
-        "materialize": true,
-        "dependencies": [
-            {
-                "js-controller": ">=1.4.2"
-            }
-        ],
-        "connectionType": "cloud",
-        "dataSource": "poll"
-    },
-    "native": {
-        "siteid": "",
-        "apikey": ""
-    },
-    "objects": [],
-    "instanceObjects": []
-}
+{
+    "common": {
+        "name": "solaredge",
+        "version": "0.2.0",
+        "news": {
+            "0.2.0": {
+                "en": "Fix updating already created states and internal polishing"
+            },
+            "0.1.1": {
+                "en": "fix \"object data is invalid\" issue, now works with new js-controller"
+            },
+            "0.1.0": {
+                "en": "First beta release",
+                "de": "Erste Beta"
+            },
+            "0.0.1": {
+                "en": "initial release",
+                "de": "Erstveröffentlichung",
+                "ru": "Начальная версия",
+                "pt": "lançamento inicial",
+                "nl": "Eerste uitgave",
+                "fr": "Première version",
+                "it": "Versione iniziale",
+                "es": "Versión inicial",
+                "pl": "Pierwsze wydanie",
+                "zh-cn": "首次出版"
+            }
+        },
+        "title": "Solaredge Monitoring",
+        "titleLang": {
+            "en": "Solaredge Monitoring",
+            "de": "Solaredge-Überwachung",
+            "ru": "Мониторинг Solaredge",
+            "pt": "Solaredge Monitoring",
+            "nl": "Solaredge Monitoring",
+            "fr": "Surveillance de Solaredge",
+            "it": "Monitoraggio di Solaredge",
+            "es": "Monitoreo Solaredge",
+            "pl": "Monitorowanie Solaredge",
+            "zh-cn": "Solaredge监控"
+        },
+        "desc": {
+            "en": "Get data from solaredge monitoring portal",
+            "de": "Rufen Sie Daten vom Solaredge-Überwachungsportal ab",
+            "ru": "Получить данные с портала мониторинга Solaredge",
+            "pt": "Obter dados do portal de monitoramento solaredge",
+            "nl": "Gegevens ophalen uit de portal voor solaredge-monitoring",
+            "fr": "Obtenez les données du portail de surveillance Solaredge",
+            "it": "Ottieni dati dal portale di monitoraggio di Solaredge",
+            "es": "Obtenga datos del portal de monitoreo de solaredge",
+            "pl": "Uzyskaj dane z portalu monitorowania Solaredge",
+            "zh-cn": "从solaredge监控门户获取数据"
+        },
+        "authors": [
+            "92lleo <[email protected]>"
+        ],
+        "keywords": [
+            "solaredge",
+            "energy",
+            "power",
+            "api",
+            "monitoring"
+        ],
+        "license": "MIT",
+        "platform": "Javascript/Node.js",
+        "main": "main.js",
+        "icon": "solaredge.png",
+        "enabled": true,
+        "extIcon": "https://raw.githubusercontent.com/92lleo/ioBroker.solaredge/master/admin/solaredge.png",
+        "readme": "https://github.com/92lleo/ioBroker.solaredge/blob/master/README.md",
+        "loglevel": "info",
+        "mode": "schedule",
+        "schedule": "*/15 * * * *",
+        "type": "energy",
+        "compact": true,
+        "materialize": true,
+        "dependencies": [
+            {
+                "js-controller": ">=3.0.0"
+            }
+        ],
+        "connectionType": "cloud",
+        "dataSource": "poll"
+    },
+    "native": {
+        "siteid": "",
+        "apikey": ""
+    },
+    "objects": [],
+    "instanceObjects": []
+}