Review for API changes #451
Merged
+126
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested with x86-64 JIT, in general the more we can avoid __index like the plague the better
|
In the future; I think we should look into the entity indexing idea; caching GetTable for only ACF entities wouldn't conflict/detour into anything, and we'd avoid that Lua -> C call each index |
|
Note: Don't merge until I make baseplates invisible to ACF.trace rather than just ballistics |
thecraftianman
approved these changes
Jan 17, 2025
|
Merging now |
|
Keep api-updates again; I may do more work on this branch @thecraftianman |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe everything here is merge-able into dev now. Beyond the API changes (non-breaking)...
The API changes were to separate user variable types (things that get changed in the menu) vs data variable types (things that get changed in gameplay, like links). There's still work to do here but that will have to come as we work with this and see what's missing/broken/still sucks