Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace BIS_fnc_param #707

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Replace BIS_fnc_param #707

wants to merge 5 commits into from

Conversation

trapw0w
Copy link
Contributor

@trapw0w trapw0w commented Jun 6, 2020 •
edited
Loading

Reference issue #705

Replacing occurrences of BIS_fnc_param with params/param for perf reasons.

Module - sys_logistics

Files:

  • fnc_canCarry
  • fnc_canLift
  • fnc_canStow
  • fnc_canTow
  • fnc_getObjectCargo
  • fnc_getObjectFuel
  • fnc_getObjectState
  • fnc_logistics
  • fnc_setObjectCargo
  • fnc_getObjectDamage
  • fnc_setObjectFuel

Testing:

  • Carry
  • Lift
  • Tow
  • Stow
  • Damage Persistence
  • Fuel Persistence
  • Cargo Persistence
  • State Persistence (Location, Direction etc)

Extra:

  • Fixed some documentation on ALIVE_fnc_setObjectFuel

Module - mil_c2istar

Files:

  • fnc_taskDestoryBuilding
  • fnc_taskOCA

Module - mil_command

Files:

  • fnc_ambush
  • fnc_commandRouters
  • fnc_garrison
  • fnc_insurgents

Module - mil_ied

Files:

  • fnc_ied

Module - mil_opcom

Files:

  • fnc_opcom

Module - mil_placement

Files:

  • fnc_mp

Module - sup_combatsupport

Files:

  • fnc_packMortar
  • fnc_unpackMortar
  • fn_setGroupID

Module - sup_groupmanager

Files:

  • fnc_gm
  • fnc_groupHandler

Module - sup_multispawn

Files:

  • fnc_establishingShotCustom
  • fnc_multispawn

Module - sup_player_resupply

Files:

  • fnc_PR

Module - sys_adminactions

Files:

  • fnc_adminActions
  • fnc_adminActionsTeleportUnits

Module - sys_data

Files:

  • fnc_data

Module - sys_gc

Files:

  • fnc_GC

Module - sys_indexer

Files:

  • fnc_indexer

Module - sys_marker

Files:

  • fnc_marker

Module - sys_newsfeed

Files:

  • fnc_newsFeed

Module - sys_player

Files:

  • fnc_getGear
  • fnc_getPlayer
  • fnc_player
  • fnc_playerInit
  • fnc_setGear
  • fnc_setPlayer
  • fnc_vehicleInit

Module - sys_tour

Files:

  • fnc_tour

Module - sys_xstream

Files:

  • fnc_camera
  • fnc_xStream

Module - x_lib

Files:

  • fnc_unorderedMap

trapw0w added 2 commits June 6, 2020 12:55
@trapw0w
Replacement of BIS_fnc_param
5dea25d 
- Changed all instances of BIS_fnc_param to param or params for performance reasons.
- Tested fuel, cargo and damage persistence
- Tested ALiVE carry, stow
@trapw0w
Cleanup
2b79ce8
@trapw0w trapw0w marked this pull request as ready for review June 6, 2020 07:40
@trapw0w trapw0w marked this pull request as draft June 8, 2020 02:57
trapw0w and others added 2 commits June 11, 2020 20:22
@trapw0w
Merge pull request #2 from ALiVEOS/master
06f2a38 
Update from Master
@trapw0w
Replace BIS_fnc_param
c2f1d4f 
Replacement of BIS_fnc_param with param/params for the following modules:
- mil_c2istar
- mil_command
- mil_ied
- mil_opcom
- mil_placement
- sup_combatsupport
- sup_group_manager
- sup_multispawn
- sup_player_resupply
- sys_adminactions
- sys_data
- sys_gc
- sys_indexer
- sys_marker
- sys_newsfeed
- sys_player
- sys_tour
- sys_xstream
- x_lib
@DarrellJMartin
Copy link
Contributor

Resolved conflicts

@DarrellJMartin
Copy link
Contributor

Please can I have a status update on this. Is it in a state where it can be merged?

@DarrellJMartin DarrellJMartin marked this pull request as ready for review July 27, 2022 11:05
@AtlasActual
Copy link

Would this be worth running some tests on? Can the performance impact be worth it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trapw0w @DarrellJMartin @AtlasActual