Refactor test

AMagistroni · Sep 10, 2021 · 861bd97 · 861bd97
1 parent 441db14
commit 861bd97
Show file tree

Hide file tree

Showing 16 changed files with 219 additions and 84 deletions.
diff --git a/SqlSchemaCompare.Core/Common/ISchemaBuilder.cs b/SqlSchemaCompare.Core/Common/ISchemaBuilder.cs
@@ -1,5 +1,4 @@
 using SqlSchemaCompare.Core.DbStructures;
-using SqlSchemaCompare.Core.TSql;
 
 namespace SqlSchemaCompare.Core.Common
 {

diff --git a/SqlSchemaCompare.Core/Common/RelatedDbObjects.cs b/SqlSchemaCompare.Core/Common/RelatedDbObjects.cs
@@ -0,0 +1,28 @@
+using SqlSchemaCompare.Core.DbStructures;
+using System.Collections.Generic;
+using System.Linq;
+
+namespace SqlSchemaCompare.Core.Common
+{
+    public class RelatedDbObjectsConfiguration
+    {
+        public static List<List<DbObjectType>> RelatedDbObjects = new List<List<DbObjectType>>
+        {
+            new List<DbObjectType> { DbObjectType.Function },
+            new List<DbObjectType> { DbObjectType.StoreProcedure },
+            new List<DbObjectType> { DbObjectType.Table, DbObjectType.TableContraint, DbObjectType.Column },
+            new List<DbObjectType> { DbObjectType.User, DbObjectType.Role, DbObjectType.Member },
+            new List<DbObjectType> { DbObjectType.View },
+            new List<DbObjectType> { DbObjectType.Schema },
+            new List<DbObjectType> { DbObjectType.Trigger, DbObjectType.EnableTrigger },
+            new List<DbObjectType> { DbObjectType.Type },
+            new List<DbObjectType> { DbObjectType.Other},
+            new List<DbObjectType> { DbObjectType.Index }
+        };
+
+        public List<DbObjectType> GetRelatedDbObjects(DbObjectType dbObject)
+        {
+            return RelatedDbObjects.Single(x => x.Contains(dbObject));
+        }
+    }
+}
diff --git a/SqlSchemaCompare.Test/TSql/TSqlFunctionTest.cs b/SqlSchemaCompare.Test/TSql/TSqlFunctionTest.cs
@@ -1,13 +1,21 @@
 using Shouldly;
+using SqlSchemaCompare.Core.Common;
 using SqlSchemaCompare.Core.DbStructures;
 using SqlSchemaCompare.Core.TSql;
+using System.Collections.Generic;
 using System.Linq;
 using Xunit;
 
 namespace SqlSchemaCompare.Test.TSql
 {
     public class TSqlFunctionTest
     {
+        private IList<DbObjectType> SelectedObjects;
+        public TSqlFunctionTest()
+        {
+            RelatedDbObjectsConfiguration relatedDbObjectsConfiguration = new();
+            SelectedObjects = relatedDbObjectsConfiguration.GetRelatedDbObjects(DbObjectType.Function);
+        }
         [Fact]
         public void CreateFunction()
         {
@@ -53,7 +61,7 @@ RETURN 3
 END
 GO";
 
-            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, new DbObjectType[] { DbObjectType.Function });
+            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, SelectedObjects);
 
             updateSchema.ShouldBeEmpty();
             errors.ShouldBeEmpty();
@@ -75,7 +83,7 @@ RETURN 3
 GO";
             const string destination = "";
 
-            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, new DbObjectType[] { DbObjectType.Function });
+            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, SelectedObjects);
 
             updateSchema.ShouldBe(
 @"CREATE FUNCTION [dbo].[func1] (@par int)
@@ -106,7 +114,7 @@ RETURN 3
 END
 GO";
 
-            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, new DbObjectType[] { DbObjectType.Function });
+            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, SelectedObjects);
 
             updateSchema.ShouldBe(
 @"DROP FUNCTION [dbo].[func1]
@@ -139,7 +147,7 @@ RETURN 10
 END
 GO";
 
-            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, new DbObjectType[] { DbObjectType.Function });
+            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, SelectedObjects);
 
             updateSchema.ShouldBe(
 @"ALTER FUNCTION [dbo].[func1] (@par int)

diff --git a/SqlSchemaCompare.Test/TSql/IndexTest.cs → SqlSchemaCompare.Test/TSql/TSqlIndexTest.cs b/SqlSchemaCompare.Test/TSql/IndexTest.cs → SqlSchemaCompare.Test/TSql/TSqlIndexTest.cs
@@ -1,13 +1,21 @@
 using Shouldly;
+using SqlSchemaCompare.Core.Common;
 using SqlSchemaCompare.Core.DbStructures;
 using SqlSchemaCompare.Core.TSql;
+using System.Collections.Generic;
 using System.Linq;
 using Xunit;
 
 namespace SqlSchemaCompare.Test.TSql
 {
-    public class IndexTest
+    public class TSqlIndexTest
     {
+        private IList<DbObjectType> SelectedObjects;
+        public TSqlIndexTest()
+        {
+            RelatedDbObjectsConfiguration relatedDbObjectsConfiguration = new();
+            SelectedObjects = relatedDbObjectsConfiguration.GetRelatedDbObjects(DbObjectType.Index);
+        }
         [Fact]
         public void CreateIndex()
         {
@@ -60,7 +68,7 @@ [ID] ASC
 )WITH (PAD_INDEX = OFF, STATISTICS_NORECOMPUTE = OFF, SORT_IN_TEMPDB = OFF, DROP_EXISTING = OFF, ONLINE = OFF, ALLOW_ROW_LOCKS = ON, ALLOW_PAGE_LOCKS = ON) ON [indexTable]
 GO";
 
-            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, new DbObjectType[] { DbObjectType.Index });
+            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, SelectedObjects);
 
             updateSchema.ShouldBeEmpty();
             errors.ShouldBeEmpty();
@@ -80,7 +88,7 @@ [ID] ASC
 GO";
             const string destination = "";
 
-            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, new DbObjectType[] { DbObjectType.Index });
+            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, SelectedObjects);
 
             updateSchema.ShouldBe(
 @"CREATE NONCLUSTERED INDEX [indexName] ON [dbo].[table]
@@ -110,7 +118,7 @@ [ID] ASC
 )WITH (PAD_INDEX = OFF, STATISTICS_NORECOMPUTE = OFF, SORT_IN_TEMPDB = OFF, DROP_EXISTING = OFF, ONLINE = OFF, ALLOW_ROW_LOCKS = ON, ALLOW_PAGE_LOCKS = ON) ON [indexTable]
 GO";
 
-            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, new DbObjectType[] { DbObjectType.Index });
+            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, SelectedObjects);
 
             updateSchema.ShouldBe(
 @"USE [dbName]
@@ -143,7 +151,7 @@ [ID] ASC
 )WITH (PAD_INDEX = OFF, STATISTICS_NORECOMPUTE = OFF, SORT_IN_TEMPDB = OFF, DROP_EXISTING = OFF, ONLINE = OFF, ALLOW_ROW_LOCKS = ON, ALLOW_PAGE_LOCKS = ON) ON [indexTable]
 GO";
 
-            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, new DbObjectType[] { DbObjectType.Index });
+            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, SelectedObjects);
 
             updateSchema.ShouldBe(
 @"DROP INDEX [indexName] ON [dbo].[table]

diff --git a/SqlSchemaCompare.Test/TSql/MemberTest.cs → SqlSchemaCompare.Test/TSql/TSqlMemberTest.cs b/SqlSchemaCompare.Test/TSql/MemberTest.cs → SqlSchemaCompare.Test/TSql/TSqlMemberTest.cs
@@ -1,13 +1,21 @@
 using Shouldly;
+using SqlSchemaCompare.Core.Common;
 using SqlSchemaCompare.Core.DbStructures;
 using SqlSchemaCompare.Core.TSql;
+using System.Collections.Generic;
 using System.Linq;
 using Xunit;
 
 namespace SqlSchemaCompare.Test.TSql
 {
-    public class MemberTest
+    public class TSqlMemberTest
     {
+        private IList<DbObjectType> SelectedObjects;
+        public TSqlMemberTest()
+        {
+            RelatedDbObjectsConfiguration relatedDbObjectsConfiguration = new();
+            SelectedObjects = relatedDbObjectsConfiguration.GetRelatedDbObjects(DbObjectType.Member);
+        }
         [Fact]
         public void CreateSchema()
         {
@@ -33,7 +41,7 @@ public void UpdateSchemaEqualsDbObject()
             const string origin = "ALTER ROLE [role] ADD MEMBER [member1]";
             const string destination = "ALTER ROLE [role] ADD MEMBER [member1]";
 
-            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, new DbObjectType[] { DbObjectType.Member });
+            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, SelectedObjects);
 
             updateSchema.ShouldBeEmpty();
             errors.ShouldBeEmpty();
@@ -48,7 +56,7 @@ public void UpdateSchemaCreateDbObject()
             const string origin = "ALTER ROLE [role] ADD MEMBER [member1]";
             const string destination = "";
 
-            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, new DbObjectType[] { DbObjectType.Member });
+            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, SelectedObjects);
 
             updateSchema.ShouldBe(
 @"ALTER ROLE [role] ADD MEMBER [member1]
@@ -67,7 +75,7 @@ public void UpdateSchemaDropDbObject()
             const string origin = "";
             const string destination = "ALTER ROLE [role] ADD MEMBER [member1]";
 
-            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, new DbObjectType[] { DbObjectType.Member });
+            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, SelectedObjects);
 
             updateSchema.ShouldBe(
 @"ALTER ROLE [role] DROP MEMBER [member1]

diff --git a/SqlSchemaCompare.Test/TSql/RoleTest.cs → SqlSchemaCompare.Test/TSql/TSqlRoleTest.cs b/SqlSchemaCompare.Test/TSql/RoleTest.cs → SqlSchemaCompare.Test/TSql/TSqlRoleTest.cs
@@ -1,13 +1,21 @@
 using Shouldly;
+using SqlSchemaCompare.Core.Common;
 using SqlSchemaCompare.Core.DbStructures;
 using SqlSchemaCompare.Core.TSql;
+using System.Collections.Generic;
 using System.Linq;
 using Xunit;
 
 namespace SqlSchemaCompare.Test.TSql
 {
-    public class RoleTest
+    public class TSqlRoleTest
     {
+        private IList<DbObjectType> SelectedObjects;
+        public TSqlRoleTest()
+        {
+            RelatedDbObjectsConfiguration relatedDbObjectsConfiguration = new();
+            SelectedObjects = relatedDbObjectsConfiguration.GetRelatedDbObjects(DbObjectType.Role);
+        }
         [Fact]
         public void CreateRole()
         {
@@ -32,7 +40,7 @@ public void UpdateSchemaEqualsDbObject()
             const string origin = "CREATE ROLE [role]";
             const string destination = "CREATE ROLE [role]";
 
-            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, new DbObjectType[] { DbObjectType.Role });
+            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, SelectedObjects);
 
             updateSchema.ShouldBeEmpty();
             errors.ShouldBeEmpty();
@@ -47,7 +55,7 @@ public void UpdateSchemaCreateDbObject()
             const string origin = "CREATE ROLE [role]";
             const string destination = "";
 
-            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, new DbObjectType[] { DbObjectType.Role });
+            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, SelectedObjects);
 
             updateSchema.ShouldBe(
 @"CREATE ROLE [role]
@@ -72,7 +80,7 @@ ALTER ROLE [role] ADD MEMBER [user]
 GO
 ";
 
-            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, new DbObjectType[] { DbObjectType.Role });
+            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, SelectedObjects);
 
             updateSchema.ShouldBe(
 @"DROP ROLE [role]

diff --git a/SqlSchemaCompare.Test/TSql/TSqlSchemaTest.cs b/SqlSchemaCompare.Test/TSql/TSqlSchemaTest.cs
@@ -1,13 +1,21 @@
 using Shouldly;
+using SqlSchemaCompare.Core.Common;
 using SqlSchemaCompare.Core.DbStructures;
 using SqlSchemaCompare.Core.TSql;
+using System.Collections.Generic;
 using System.Linq;
 using Xunit;
 
 namespace SqlSchemaCompare.Test.TSql
 {
     public class TSqlSchemaTest
     {
+        private IList<DbObjectType> SelectedObjects;
+        public TSqlSchemaTest()
+        {
+            RelatedDbObjectsConfiguration relatedDbObjectsConfiguration = new();
+            SelectedObjects = relatedDbObjectsConfiguration.GetRelatedDbObjects(DbObjectType.Schema);
+        }
         [Fact]
         public void CreateSchema()
         {
@@ -33,7 +41,7 @@ public void UpdateSchemaEqualsDbObject()
             const string origin = "CREATE SCHEMA [sch1]";
             const string destination = "CREATE SCHEMA [sch1]";
 
-            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, new DbObjectType[] { DbObjectType.Schema });
+            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, SelectedObjects);
 
             updateSchema.ShouldBeEmpty();
         }
@@ -47,7 +55,7 @@ public void UpdateSchemaCreateDbObject()
             const string origin = "CREATE SCHEMA [sch1]";
             const string destination = "";
 
-            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, new DbObjectType[] { DbObjectType.Schema });
+            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, SelectedObjects);
 
             updateSchema.ShouldBe(
 @"CREATE SCHEMA [sch1]
@@ -66,7 +74,7 @@ public void UpdateSchemaDropDbObject()
             const string origin = "";
             const string destination = "CREATE SCHEMA [sch1]";
 
-            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, new DbObjectType[] { DbObjectType.Schema });
+            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, SelectedObjects);
 
             updateSchema.ShouldBe(
 @"DROP SCHEMA [sch1]

diff --git a/SqlSchemaCompare.Test/TSql/TSqlStoreProcedureTest.cs b/SqlSchemaCompare.Test/TSql/TSqlStoreProcedureTest.cs
@@ -1,13 +1,21 @@
 using Shouldly;
+using SqlSchemaCompare.Core.Common;
 using SqlSchemaCompare.Core.DbStructures;
 using SqlSchemaCompare.Core.TSql;
+using System.Collections.Generic;
 using System.Linq;
 using Xunit;
 
 namespace SqlSchemaCompare.Test.TSql
 {
     public class TSqlStoreProcedureTest
     {
+        private IList<DbObjectType> SelectedObjects;
+        public TSqlStoreProcedureTest()
+        {
+            RelatedDbObjectsConfiguration relatedDbObjectsConfiguration = new();
+            SelectedObjects = relatedDbObjectsConfiguration.GetRelatedDbObjects(DbObjectType.StoreProcedure);
+        }
         [Fact]
         public void CreateStoreProcedure()
         {
@@ -51,7 +59,7 @@ public void UpdateSchemaEqualsDbObject()
 END 
 GO";
 
-            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, new DbObjectType[] { DbObjectType.StoreProcedure });
+            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, SelectedObjects);
 
             updateSchema.ShouldBeEmpty();
             errors.ShouldBeEmpty();
@@ -73,7 +81,7 @@ public void UpdateSchemaCreateDbObject()
 GO";
             const string destination = "";
 
-            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, new DbObjectType[] { DbObjectType.StoreProcedure });
+            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, SelectedObjects);
 
             updateSchema.ShouldBe(
 @"CREATE PROCEDURE [dbo].[proc]
@@ -104,7 +112,7 @@ public void UpdateSchemaDropDbObject()
 END 
 GO";
 
-            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, new DbObjectType[] { DbObjectType.StoreProcedure });
+            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, SelectedObjects);
 
             updateSchema.ShouldBe(
 @"DROP PROCEDURE [dbo].[proc]
@@ -137,7 +145,7 @@ public void UpdateSchemaAlterDbObject()
 END
 GO";
 
-            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, new DbObjectType[] { DbObjectType.StoreProcedure });
+            (string updateSchema, string errors) = UtilityTest.UpdateSchema(origin, destination, SelectedObjects);
 
             updateSchema.ShouldBe(
 @"ALTER PROCEDURE [dbo].[proc]