Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/importing images #106

Merged
merged 10 commits into from
Sep 4, 2024
Merged

Fix/importing images #106

merged 10 commits into from
Sep 4, 2024

Conversation

JeongWo
Copy link
Collaborator

@JeongWo JeongWo commented Sep 4, 2024

๐Ÿ“• Issue Number

Close #14

๐Ÿ“™ ์ž‘์—… ๋‚ด์—ญ

๊ตฌํ˜„ ๋‚ด์šฉ ๋ฐ ์ž‘์—… ํ–ˆ๋˜ ๋‚ด์—ญ
ํŽธ์ง€ ๋ณด๊ด€ํ•˜๊ธฐ ๋ฒ„ํŠผ ํด๋ฆญ ์‹œ LetterBoxView๋กœ ์ด๋™
๊ฒ€์ƒ‰ ์˜คํƒ€ ๋ฐ ๋ฆฌํŒฉํ† ๋ง LetterWritingView
์ถ”์‹  ์šฐํ‘œ ํŽธ์ง€๋ด‰ํˆฌ ๋ฏธ๋ฆฌ๋ณด๊ธฐ ์˜ค๋ฅ˜ ์ˆ˜์ •
ํŒŒ์ด์–ด๋ฒ ์ด์Šค ์—ฐ๊ฒฐ
๋””์ž์ธ ์ˆ˜์ •(OptionOverlay ์œ„์น˜ ํฌ๊ธฐ, ์œ ์ €๊ฒ€์ƒ‰, ๋‚ ์งœ)

๐Ÿ“˜ ์ž‘์—… ์œ ํ˜•

  • ์‹ ๊ทœ ๊ธฐ๋Šฅ ์ถ”๊ฐ€
  • ๋ฒ„๊ทธ ์ˆ˜์ •
  • ๋ฆฌํŽ™ํ† ๋ง
  • ๋ฌธ์„œ ์—…๋ฐ์ดํŠธ

๐Ÿ“‹ ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • Merge ํ•˜๋Š” ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€?
  • ์ฝ”๋”ฉ์ปจ๋ฒค์…˜์„ ์ค€์ˆ˜ํ•˜๋Š”๊ฐ€?
  • PR๊ณผ ๊ด€๋ จ์—†๋Š” ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ์—†๋Š”๊ฐ€?
  • ๋‚ด ์ฝ”๋“œ์— ๋Œ€ํ•œ ์ž๊ธฐ ๊ฒ€ํ† ๊ฐ€ ๋˜์—ˆ๋Š”๊ฐ€?
  • ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ํšจ๊ณผ์ ์ด๊ฑฐ๋‚˜ ๋™์ž‘์ด ์ž‘๋™ํ•œ๋‹ค๋Š” ๊ฒƒ์„ ๋ณด์ฆํ•˜๋Š” ํ…Œ์ŠคํŠธ๋ฅผ ์ถ”๊ฐ€ํ•˜์˜€๋Š”๊ฐ€?



@@ -170,6 +193,7 @@ struct KabinettApp: App {
.environmentObject(stationerySelectionViewModel)
.environmentObject(fontSelectionViewModel)
.environmentObject(writerLetterViewModel)
.environmentObject(writerLetterViewModel)
Copy link
Collaborator

@the-hye the-hye Sep 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์œ—์ค„๊ณผ ์ค‘๋ณต๋˜๋„ค์š”~

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•— ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค! ์ˆ˜์ •ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค~

@ksiomng ksiomng merged commit 22308c3 into Develop Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] ์‚ฌ์ง„ ๋ถˆ๋Ÿฌ์˜ค๊ธฐ ๊ตฌํ˜„
4 participants