Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/remove photo #159

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Fix/remove photo #159

merged 3 commits into from
Sep 11, 2024

Conversation

the-hye
Copy link
Collaborator

@the-hye the-hye commented Sep 11, 2024

πŸ“• Issue Number

Close #158

πŸ“™ μž‘μ—… λ‚΄μ—­

κ΅¬ν˜„ λ‚΄μš© 및 μž‘μ—… ν–ˆλ˜ λ‚΄μ—­

  • Letter μ‚­μ œμ‹œ λ™λ΄‰λœ 사진 Storage에 ν•¨κ»˜ μ‚­μ œ

πŸ“˜ μž‘μ—… μœ ν˜•

  • μ‹ κ·œ κΈ°λŠ₯ μΆ”κ°€
  • 버그 μˆ˜μ •
  • λ¦¬νŽ™ν† λ§
  • λ¬Έμ„œ μ—…λ°μ΄νŠΈ

πŸ“‹ 체크리슀트

  • Merge ν•˜λŠ” λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€?
  • μ½”λ”©μ»¨λ²€μ…˜μ„ μ€€μˆ˜ν•˜λŠ”κ°€?
  • PRκ³Ό κ΄€λ ¨μ—†λŠ” 변경사항이 μ—†λŠ”κ°€?
  • λ‚΄ μ½”λ“œμ— λŒ€ν•œ 자기 κ²€ν† κ°€ λ˜μ—ˆλŠ”κ°€?
  • 변경사항이 νš¨κ³Όμ μ΄κ±°λ‚˜ λ™μž‘μ΄ μž‘λ™ν•œλ‹€λŠ” 것을 λ³΄μ¦ν•˜λŠ” ν…ŒμŠ€νŠΈλ₯Ό μΆ”κ°€ν•˜μ˜€λŠ”κ°€?

πŸ“ PR 특이 사항

PR을 λ³Ό λ•Œ 주의깊게 λ΄μ•Όν•˜κ±°λ‚˜ λ§ν•˜κ³  싢은 점

  • 특이 사항 1
    νŽΈμ§€ μ‚­μ œ μ‹œ λ™λ΄‰λœ 사진 λ˜ν•œ Storageμ—μ„œ μ œκ±°λ©λ‹ˆλ‹€~

@the-hye the-hye self-assigned this Sep 11, 2024
uunwon
uunwon approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@uunwon uunwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘πŸ»πŸ‘πŸ»

@ksiomng ksiomng mentioned this pull request Sep 11, 2024
Closed
25 tasks
@YuleGlycerine YuleGlycerine merged commit a6938a4 into Develop Sep 11, 2024
1 check passed
@the-hye the-hye deleted the Fix/RemovePhoto branch November 6, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuleGlycerine YuleGlycerine YuleGlycerine approved these changes

@uunwon uunwon uunwon approved these changes

Assignees

@the-hye the-hye

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RemoteDB] Letter μ‚­μ œμ‹œ photoContents ν•¨κ»˜ μ‚­μ œ
3 participants
@the-hye @uunwon @YuleGlycerine