Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/custom tab view #229

Merged
merged 4 commits into from
Nov 10, 2024
Merged

Fix/custom tab view #229

merged 4 commits into from
Nov 10, 2024

Conversation

JeongWo
Copy link
Collaborator

@JeongWo JeongWo commented Oct 8, 2024

πŸ“• Issue Number

Close #227 #228

πŸ“™ μž‘μ—… λ‚΄μ—­

κ΅¬ν˜„ λ‚΄μš© 및 μž‘μ—… ν–ˆλ˜ λ‚΄μ—­

  • νƒ­λ·° 클릭 μ‹œ μƒμœ„λ·°λ‘œ 이동 및 μ½”λ“œμ •λ¦¬

πŸ“˜ μž‘μ—… μœ ν˜•

  • μ‹ κ·œ κΈ°λŠ₯ μΆ”κ°€
  • 버그 μˆ˜μ •
  • λ¦¬νŽ™ν† λ§
  • λ¬Έμ„œ μ—…λ°μ΄νŠΈ

πŸ“‹ 체크리슀트

  • Merge ν•˜λŠ” λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯Έκ°€?
  • μ½”λ”©μ»¨λ²€μ…˜μ„ μ€€μˆ˜ν•˜λŠ”κ°€?
  • PRκ³Ό κ΄€λ ¨μ—†λŠ” 변경사항이 μ—†λŠ”κ°€?
  • λ‚΄ μ½”λ“œμ— λŒ€ν•œ 자기 κ²€ν† κ°€ λ˜μ—ˆλŠ”κ°€?
  • 변경사항이 νš¨κ³Όμ μ΄κ±°λ‚˜ λ™μž‘μ΄ μž‘λ™ν•œλ‹€λŠ” 것을 λ³΄μ¦ν•˜λŠ” ν…ŒμŠ€νŠΈλ₯Ό μΆ”κ°€ν•˜μ˜€λŠ”κ°€?

jinwoong16
jinwoong16 approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@jinwoong16 jinwoong16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€
NotificationCenterλ₯Ό μ‚¬μš©ν•˜μ…¨λŠ”λ°, NotificationCenterλŠ” μ „μ—­μœΌλ‘œ 이벀트λ₯Ό μ†‘μ‹ ν•΄μ„œ μ–΄λŠ κ³³μ—μ„œλ“  μˆ˜μ‹ λ°›μ„ μˆ˜κ°€ μžˆλŠ”λ°μš”. 이 λ•Œλ¬Έμ— μ„±λŠ₯κ³Ό κ΄€λ ¨λœ 글듀을 λͺ‡λ²ˆ λ³Έκ±°κ°™μ•„μš”. μ°Ύμ•„λ³΄λ €λ‹ˆ 잘 μ•ˆλ³΄μ΄λ„€μš”... κ·Έμƒˆ λ³€κ²½λœκ±΄μ§€...
μ¨Œλ“ , μ§€κΈˆ 상황은 νƒ­λ·° λ‚΄μ—μ„œ μΌμ–΄λ‚˜λŠ” μΌμ΄λ‹ˆ μ „μ—­μœΌλ‘œ 말고 νƒ­λ·°λ‚΄μ—μ„œ μ²˜λ¦¬ν•  수 μžˆλŠ” 방법도 μžˆμ„κ²ƒκ°™μ•„μš”! μ–΄μ©Œλ©΄ λ¦¬νŒ©ν† λ§ ν•΄λ³Ό 수 μžˆμ„μ§€λ„??

@JeongWo JeongWo merged commit 9c918df into Develop Nov 10, 2024
@JeongWo JeongWo deleted the Fix/CustomTabView branch November 14, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinwoong16 jinwoong16 jinwoong16 approved these changes

Assignees

@JeongWo JeongWo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

νƒ­λ·° 각 νƒ­ 클릭 μ‹œ μ΅œμƒμœ„ 뷰둜
2 participants
@JeongWo @jinwoong16