Feature/동봉된 사진 확대 및 저장 #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Kabinett into Refactor/LetterBoxView
…Kabinett into Refactor/LetterBoxView
…Kabinett into Refactor/LetterBoxView # Conflicts: # Kabinett/Presentation/View/LetterBox/Components/ContentRectangleView.swift # Kabinett/Presentation/View/LetterBox/LetterBoxDetailView.swift # Kabinett/Presentation/View/LetterBox/LetterBoxView.swift
This reverts commit b4c6d9f.
jinwoong16
approved these changes
Nov 11, 2024
Comment on lines
55
to
66
| func savePhotoToAlbum() { | ||
| guard let url = URL(string: photoUrl) else { return } | ||
| URLSession.shared.dataTask(with: url) { data, response, error in | ||
| if let data = data, let image = UIImage(data: data) { | ||
| DispatchQueue.main.async { | ||
| UIImageWriteToSavedPhotosAlbum(image, nil, nil, nil) | ||
| } | ||
| } else { | ||
| print("사진을 불러오지 못했습니다.", error?.localizedDescription ?? "알 수 없는 오류") | ||
| } | ||
| }.resume() | ||
| } |
There was a problem hiding this comment.
콜백기반의 비동기처리보다는 Swift Concurrency나 Combine을 통한 비동기 처리를 권장드려요
이 방식은 이제 잘 안쓰여요... Swift Concurrency 소개할 때, 콜백기반의 비동기 처리가 왜 안좋은지 설명을 하니, 한번 참고해보시면 좋겠습니다.
There was a problem hiding this comment.
마구잡이로 코딩하지 않게 알려주셔서 감사해요 . . 기억두겠습니닷 ✍🏻
|
신속정확하심니다 . . 확대도 되고 저장도 된다니 초초초 필수기능이 생겼자나~~ 짱이어요 .. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📕 Issue Number
Close #254
📙 작업 내역
📘 작업 유형
📋 체크리스트
📝 PR 특이 사항
헉. Dev에서 브랜치를 만든게 아니고 아직 Dev에 머지되지 않은 제 브랜치에서 생성해서 커밋이 조금 많아 보이네요.
Feat: PhotoDetailView 생성부터 보면 된답니다..📱 서비스 화면