Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Resetting the view on tab clicks #256

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Fix: Resetting the view on tab clicks #256

merged 1 commit into from
Nov 18, 2024

Conversation

JeongWo
Copy link
Collaborator

@JeongWo JeongWo commented Nov 14, 2024

๐Ÿ“• Issue Number

Close #227

๐Ÿ“™ ์ž‘์—… ๋‚ด์—ญ

๊ตฌํ˜„ ๋‚ด์šฉ ๋ฐ ์ž‘์—… ํ–ˆ๋˜ ๋‚ด์—ญ

  • ํƒญ ํด๋ฆญ ์‹œ ๊ฐ ๋ทฐ์˜ ๋„ค๋น„๊ฒŒ์ด์…˜ ์Šคํƒ ์ดˆ๊ธฐํ™”

๐Ÿ“˜ ์ž‘์—… ์œ ํ˜•

  • ์‹ ๊ทœ ๊ธฐ๋Šฅ ์ถ”๊ฐ€
  • ๋ฒ„๊ทธ ์ˆ˜์ •
  • ๋ฆฌํŽ™ํ† ๋ง
  • ๋ฌธ์„œ ์—…๋ฐ์ดํŠธ

๐Ÿ“‹ ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • Merge ํ•˜๋Š” ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅธ๊ฐ€?
  • ์ฝ”๋”ฉ์ปจ๋ฒค์…˜์„ ์ค€์ˆ˜ํ•˜๋Š”๊ฐ€?
  • PR๊ณผ ๊ด€๋ จ์—†๋Š” ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ์—†๋Š”๊ฐ€?
  • ๋‚ด ์ฝ”๋“œ์— ๋Œ€ํ•œ ์ž๊ธฐ ๊ฒ€ํ† ๊ฐ€ ๋˜์—ˆ๋Š”๊ฐ€?
  • ๋ณ€๊ฒฝ์‚ฌํ•ญ์ด ํšจ๊ณผ์ ์ด๊ฑฐ๋‚˜ ๋™์ž‘์ด ์ž‘๋™ํ•œ๋‹ค๋Š” ๊ฒƒ์„ ๋ณด์ฆํ•˜๋Š” ํ…Œ์ŠคํŠธ๋ฅผ ์ถ”๊ฐ€ํ•˜์˜€๋Š”๊ฐ€?

๐Ÿ“ PR ํŠน์ด ์‚ฌํ•ญ

PR์„ ๋ณผ ๋•Œ ์ฃผ์˜๊นŠ๊ฒŒ ๋ด์•ผํ•˜๊ฑฐ๋‚˜ ๋งํ•˜๊ณ  ์‹ถ์€ ์ 

  • ์ €๋ฒˆ PR์—์„œ ProfileView์™€ LetterBoxView์˜ Navigation ๊ด€๋ จ ์ฝ”๋“œ๊ฐ€ ๋ˆ„๋ฝ๋˜์–ด ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

์ˆ˜์ •์‚ฌํ•ญ:

  • ProfileView์™€ LetterBoxView์— CustomTabViewModel ์ฃผ์ž…

    • ObservedObject customTabViewModel ์ถ”๊ฐ€
    • ๊ฐ View์˜ init์— customTabViewModel ํŒŒ๋ผ๋ฏธํ„ฐ ์ถ”๊ฐ€
  • LetterBoxView:

    • NavigationStack์— customTabViewModel.letterBoxNavigationPath ๋ฐ”์ธ๋”ฉ ์ถ”๊ฐ€
    • NavigationLink๋ฅผ destination ๋ฐฉ์‹์—์„œ value ๋ฐฉ์‹์œผ๋กœ ๋ณ€๊ฒฝ
    • navigationDestination ๋ชจ๋””ํŒŒ์ด์–ด๋ฅผ ํ†ตํ•ด ํƒ€์ž… ๊ธฐ๋ฐ˜ ๋„ค๋น„๊ฒŒ์ด์…˜ ๊ตฌํ˜„
  • ProfileView:

    • ํƒญ ํด๋ฆญ ์‹œ ๋„ค๋น„๊ฒŒ์ด์…˜ ๋ฆฌ์…‹ ๊ธฐ๋Šฅ ์ถ”๊ฐ€
    • NotificationCenter๋ฅผ ํ†ตํ•œ resetProfileNavigation ๊ตฌํ˜„



@JeongWo JeongWo merged commit 4a3a6ed into Develop Nov 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ํƒญ๋ทฐ ๊ฐ ํƒญ ํด๋ฆญ ์‹œ ์ตœ์ƒ์œ„ ๋ทฐ๋กœ
2 participants