-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ark-cli crate #13
Add ark-cli crate #13
Conversation
* Bump arklib version * Added tokio to deal with futures * Updating the index when links are added * Update GitHub Actions --------- Co-authored-by: Alvi Hysa <[email protected]>
657d48e
to
28806f0
Compare
Signed-off-by: Tarek <[email protected]>
28806f0
to
68def70
Compare
Signed-off-by: Tarek <[email protected]>
The branch `ark-rust_hot_fix` contains a hot fix where we use the same commit specified when writing `ark-cli` but with pinning `image` crate to the correct version so that `ark-rust` can compile This is just a hot fix. `arklib` shouldn't be even a dependency of any `ark-rust` crate. See ARK-Builders#15 for more information Signed-off-by: Tarek <[email protected]>
14975d6
to
231a6ce
Compare
Ok so I refactored the PR Changes Made:
Advantages:
Disadvantages:
|
To justify 231a6ce:Currently,
As a hot fix, I made a new branch https://github.com/ARK-Builders/arklib/tree/ark-rust_hot_fix aligning with the same commit as |
@tareknaser good work, I think solution using |
Glad to see this pull request merged! |
I've merged the PR. The commits in After second thought, it makes sense because @kirillt What's your take on the current approach? Are you content with it, or do you lean towards rewriting the git history of |
This pull request adds the
ark-cli
crate into theark-rust
workspace.Changes made:
Relocated all
ark-cli
code into a new crate.Next steps
currently,
ark-cli
still depends onark-lib
We should make it depend on other crates from the workspace