Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Arklib into Separate Crates #5

Merged
merged 64 commits into from
Mar 1, 2024
Merged

Refactor Arklib into Separate Crates #5

merged 64 commits into from
Mar 1, 2024

Conversation

tareknaser
Copy link
Collaborator

@tareknaser tareknaser commented Feb 21, 2024 •
edited by kirillt
Loading

This PR refactors Arklib into three separate crates for better organization and modularity:

  1. fs-atomic-versions: Manages the app_id file
  2. fs-index: Handles resource index management
  3. fs-utils: Contains utility functions and common code used across the project.

Additionally, this PR relocates the README.md, fonts/, and testdata/ directories to the project's root directory

  • Change target of the PR from monorepo to main before merging

sisco0 and others added 30 commits January 17, 2022 21:00
@sisco0 @kirillt
Create Github Actions ci
243177c 
Use Github Actions template for Rust
@sisco0 @kirillt
Created library, test and android bindings
92a3093
@kirillt
Android wrapper moved to separate repo
90ca27a
@kirillt
Rlib instead of Dylib
052832d
@kirillt
Tag storage filename exposed
508526d
@kirillt
Using u32 for CRC-32 instead of i64
a97dda2
@kirillt
Update README.md
f542da7
@kirillt
Using u64 for file sizes
a127c38
@kirillt
Index construction
0de0e27
@kirillt
Capability to keep several indexes in the same process
bdf2377
@kirillt
Scanning resource metadata
92de06f
@kirillt
Incremental index updates
0c3cdd3
@kirillt
Filtering directories from discovered paths
0f711b8
@kirillt
Index update fixed for the case of having duplicates
e834f48
@zannis
Cover index build and update with unit tests (#7)
b90b80f
@kirillt
TODO removed, see issue #6
d1edd0f
@j4w3ny
Add PDF previews generator (#12)
2874508
@kirillt
cargo fmt to the rescue
e32c781
@j4w3ny
Fix Pdfium PDF Render On Android (#17)
cc7b2e6
@kirillt
Bump dependencies version and enable thread-safe feature of pdfium-re…
cdb8ae2 
…nder (#18)

Authored-by: Jerry Wong <[email protected]>
@j4w3ny
use Reader trait for providing a better performance (#19)
e2fd66d
@hhio618
Feat: Add Link-to-Web resource kind (#20)
b743977
@hhio618
Set Link fields to public
de36578
@hhio618
Add syned function of get_preview
7d8c537
@hhio618 @kirillt
Set Link fields to public
ed1ef80
@hhio618 @kirillt
Add link metadata
4f0d8cb
@hhio618 @kirillt
Add metadata storage
8133398
@hhio618 @kirillt
Some fixes
f150440
@kirillt
Metadata loading
2e2fd46
@kirillt
Reading/writing resource index
96f1bba
gwendalF and others added 13 commits December 14, 2023 19:18
@gwendalF @kirillt @GwendalFernet
#48: Atomic files (#50)
0d25eb0 
Co-authored-by: Kirill Taran <[email protected]>
Co-authored-by: Gwendal Fernet <[email protected]>
@alvinosh
#54: Replace machine-id with stored uuid (#64)
1249e6c 
* Replacing machine-id with custom stored uuid.

* Changed Name From device_id to app_id

* Made Function Public

* Loaded App Id On Remaining Tests

* Fixed Tests

* Renamed Folder
@alvinosh
AtomicFile fields made public
c936729
@kirillt
Minor enhancements
2c7ceda
@kirillt
Print details of IO errors
68a5b66
@kirillt
Remove unused function
58248d1
@kirillt
Add index_new function for lightweight indexing of new paths
79b101c
@kirillt
Update README.md
b3641d4
@tareknaser
#65: Add Hash Function Benchmarks (#74)
1c8a37b 
This commit introduces a new benchmark file, benches/hash_benchmark.rs. The file includes the compute_bytes_benchmark function, which has three benchmarks for different use cases:
- compute_bytes_small: Benchmarks with small input data.
- compute_bytes_medium: Evaluates medium-sized input data.
- compute_bytes_large: Measures large input data performance.

Criterion is configured as a dev dependency with the `html_reports` feature for detailed HTML reports in `target/criterion/`.

Signed-off-by: Tarek <[email protected]>
@kirillt
A bit more info during pre-benchmark assessment
7bf1ce9
@tareknaser
[Rustfmt] Remove Deprecated Tags report_fixme and report_todo fro…
f0156bd 
…m Configuration (#82)
@gwendalF
#70: Fix cross-devices issues
357e62f
@kirillt
Splitting the arklib into separate modules
b27912c
@tareknaser
Copy link
Collaborator Author

Note: Run benchmarks check is failing because the main branch still doesn't have benchmarks

@kirillt kirillt changed the base branch from main to monorepo February 21, 2024 15:20
@tareknaser tareknaser mentioned this pull request Feb 26, 2024
Merged
kirillt
kirillt reviewed Feb 28, 2024
View reviewed changes
data-resource/src/lib.rs Outdated Show resolved Hide resolved
fs-index/src/pdf.rs Outdated Show resolved Hide resolved
fs-index/src/link.rs Outdated Show resolved Hide resolved
fs-index/src/lib.rs Outdated Show resolved Hide resolved
fs-utils/src/lib.rs Outdated Show resolved Hide resolved
@tareknaser tareknaser requested a review from kirillt February 29, 2024 19:52
tareknaser and others added 3 commits March 1, 2024 18:48
@tareknaser @kirillt
Improve crates structure
8f7d482 
Signed-off-by: Tarek <[email protected]>
@kirillt
Minor enhancements
45dc880 
Signed-off-by: Tarek <[email protected]>
@tareknaser @kirillt
Add more crates
c70b963 
- data-pdf
- data-error
- data-json
- data-link
- fs-storage
- fs-atomic-light
- data-json (ex fs-utils)
- data-error (ex fs-utils)
@kirillt kirillt changed the base branch from monorepo to main March 1, 2024 15:49
kirillt
kirillt approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@kirillt kirillt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tareknaser

@kirillt kirillt merged commit d42300d into main Mar 1, 2024
@tareknaser tareknaser deleted the crate-org branch March 1, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirillt kirillt kirillt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@tareknaser @kirillt @sisco0 @zannis @j4w3ny @hhio618 @gwendalF @Rizary @alvinosh