Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly assign arguments to avoid incorrect argument assignments #389

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

poppopting
Copy link
Contributor

@poppopting poppopting commented Oct 21, 2024

What does this PR do?

  1. Fix an incorrect argument assignments inside MultiLabelEstimator.fit()
  2. Explicitly assign arguments in MultiLabelEstimator.score() and thus enable grid search for linear multi-class problem
  3. align assign arguments in LINEAR_TECHNIQUES inside linear_trainer.py

(Some descriptions here...)

Test CLI & API (bash tests/autotest.sh)

Test APIs used by main.py.

  • Test Pass
    • (Copy and paste the last outputted line here.)
  • Not Applicable (i.e., the PR does not include API changes.)

Check API Document

If any new APIs are added, please check if the description of the APIs is added to API document.

  • API document is updated (linear, nn)
  • Not Applicable (i.e., the PR does not include API changes.)

Test quickstart & API (bash tests/docs/test_changed_document.sh)

If any APIs in quickstarts or tutorials are modified, please run this test to check if the current examples can run correctly after the modified APIs are released.

@Eleven1Liu Eleven1Liu added bug Something isn't working enhancement New feature or request, or code polishing labels Oct 22, 2024
@Eleven1Liu Eleven1Liu merged commit 6e8fa71 into ASUS-AICS:master Oct 22, 2024
1 check passed
@poppopting poppopting deleted the ktdev branch October 22, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request, or code polishing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants