Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add clang qualtype to methods' parameter's type #58

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: add clang qualtype to methods' parameter's type #58

wants to merge 3 commits into from

Conversation

WinterPu
Copy link

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 17, 2025
View reviewed changes
cxx-parser/src/utils.ts

// dump_clang_ast_<file name>_<checksum>.json
let clangAstJsonPath = path.join(
buildDir,

Check warning

Code scanning / CodeQL

Unsafe shell command constructed from library input Medium

This path concatenation which depends on
library input
Loading
is later used in a
shell command
Loading
.
This path concatenation which depends on
library input
Loading
is later used in a
shell command
Loading
.
cxx-parser/src/utils.ts
let args = ['-Xclang', '-ast-dump=json', '-fsyntax-only', '-std=c++11'];
let _args = [...args, ...includeHeaderDirsArgs, parseFile].join(' ');

let bashScript = `clang++ ${_args} > ${clangAstJsonPath}`;

Check warning

Code scanning / CodeQL

Unsafe shell command constructed from library input Medium

This string concatenation which depends on
library input
Loading
is later used in a
shell command
Loading
.
This string concatenation which depends on
library input
Loading
is later used in a
shell command
Loading
.
cxx-parser/src/utils.ts
console.log(`Running command: \n${bashScript}`);

try {
execSync(bashScript, {

Check warning

Code scanning / CodeQL

Shell command built from environment values Medium

This shell command depends on an uncontrolled
absolute path
Loading
.
WinterPu added 2 commits January 17, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peilinok peilinok Awaiting requested review from peilinok

@xiayangqun xiayangqun Awaiting requested review from xiayangqun

@guoxianzhe guoxianzhe Awaiting requested review from guoxianzhe

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@WinterPu