Skip to content

Commit

Permalink
cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
AnakinRaW committed Aug 3, 2024
1 parent 7e4d29c commit 596a01c
Show file tree
Hide file tree
Showing 24 changed files with 38 additions and 44 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,6 @@ jobs:
# Change into the artifacts directory to avoid including the directory itself in the zip archive
working-directory: ./releases/net8.0
run: zip -r ../ModVerify-Net8.zip .
- name: Rename .NET Framework executable
run: mv ./releases/net48/ModVerify.CliApp.exe ./releases/net48/ModVerify.exe
- uses: dotnet/[email protected]
id: nbgv
- name: Create GitHub release
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ A `.JSON` file lists all found issues. Into seperate `.txt` files the same error

You can also run the tool with command line arguments to adjust the tool to your needs.

To see all available options, open the command line and type:
To see all available options, especially if you have custom folder setups, open the command line and type:

```bash
ModVerify.exe --help
Expand Down
2 changes: 1 addition & 1 deletion src/ModVerify.CliApp/ExtensionMethods.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using PG.StarWarsGame.Engine;
using PG.StarWarsGame.Infrastructure.Games;

namespace ModVerify.CliApp;
namespace AET.ModVerifyTool;

internal static class ExtensionMethods
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
using PG.StarWarsGame.Infrastructure.Games;

namespace ModVerify.CliApp;
namespace AET.ModVerifyTool.GameFinder;

internal record GameFinderResult(IGame Game, IGame? FallbackGame);
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
using PG.StarWarsGame.Infrastructure.Services.Dependencies;
using PG.StarWarsGame.Infrastructure.Services.Detection;

namespace ModVerify.CliApp;
namespace AET.ModVerifyTool.GameFinder;

internal class GameFinderService
{
Expand Down
2 changes: 1 addition & 1 deletion src/ModVerify.CliApp/GameNotFoundException.cs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
using PG.StarWarsGame.Infrastructure.Games;

namespace ModVerify.CliApp;
namespace AET.ModVerifyTool;

internal class GameNotFoundException(string message) : GameException(message);
10 changes: 0 additions & 10 deletions src/ModVerify.CliApp/ModSelectionResult.cs

This file was deleted.

5 changes: 3 additions & 2 deletions src/ModVerify.CliApp/ModSelectors/AutomaticModSelector.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,20 @@
using System.Diagnostics;
using System.Globalization;
using System.IO.Abstractions;
using AET.ModVerifyTool.GameFinder;
using AET.ModVerifyTool.Options;
using EawModinfo.Model;
using EawModinfo.Spec;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Logging;
using ModVerify.CliApp.Options;
using PG.StarWarsGame.Engine;
using PG.StarWarsGame.Infrastructure;
using PG.StarWarsGame.Infrastructure.Games;
using PG.StarWarsGame.Infrastructure.Mods;
using PG.StarWarsGame.Infrastructure.Services;
using PG.StarWarsGame.Infrastructure.Services.Dependencies;

namespace ModVerify.CliApp.ModSelectors;
namespace AET.ModVerifyTool.ModSelectors;

internal class AutomaticModSelector(IServiceProvider serviceProvider) : ModSelectorBase(serviceProvider)
{
Expand Down
5 changes: 3 additions & 2 deletions src/ModVerify.CliApp/ModSelectors/ConsoleModSelector.cs
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
using System;
using System.Collections.Generic;
using AET.ModVerifyTool.GameFinder;
using AET.ModVerifyTool.Options;
using EawModinfo.Spec;
using ModVerify.CliApp.Options;
using PG.StarWarsGame.Engine;
using PG.StarWarsGame.Infrastructure;
using PG.StarWarsGame.Infrastructure.Mods;

namespace ModVerify.CliApp.ModSelectors;
namespace AET.ModVerifyTool.ModSelectors;

internal class ConsoleModSelector(IServiceProvider serviceProvider) : ModSelectorBase(serviceProvider)
{
Expand Down
4 changes: 2 additions & 2 deletions src/ModVerify.CliApp/ModSelectors/IModSelector.cs
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
using ModVerify.CliApp.Options;
using AET.ModVerifyTool.Options;
using PG.StarWarsGame.Engine;
using PG.StarWarsGame.Infrastructure;

namespace ModVerify.CliApp.ModSelectors;
namespace AET.ModVerifyTool.ModSelectors;

internal interface IModSelector
{
Expand Down
4 changes: 2 additions & 2 deletions src/ModVerify.CliApp/ModSelectors/ManualModSelector.cs
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
using System;
using ModVerify.CliApp.Options;
using AET.ModVerifyTool.Options;
using PG.StarWarsGame.Engine;
using PG.StarWarsGame.Infrastructure;

namespace ModVerify.CliApp.ModSelectors;
namespace AET.ModVerifyTool.ModSelectors;

internal class ManualModSelector(IServiceProvider serviceProvider) : ModSelectorBase(serviceProvider)
{
Expand Down
5 changes: 3 additions & 2 deletions src/ModVerify.CliApp/ModSelectors/ModSelectorBase.cs
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
using System;
using System.Collections.Generic;
using System.Linq;
using AET.ModVerifyTool.GameFinder;
using AET.ModVerifyTool.Options;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Logging;
using ModVerify.CliApp.Options;
using PG.StarWarsGame.Engine;
using PG.StarWarsGame.Infrastructure;
using PG.StarWarsGame.Infrastructure.Mods;
using PG.StarWarsGame.Infrastructure.Services.Dependencies;

namespace ModVerify.CliApp.ModSelectors;
namespace AET.ModVerifyTool.ModSelectors;

internal abstract class ModSelectorBase : IModSelector
{
Expand Down
4 changes: 2 additions & 2 deletions src/ModVerify.CliApp/ModSelectors/ModSelectorFactory.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using System;
using ModVerify.CliApp.Options;
using AET.ModVerifyTool.Options;

namespace ModVerify.CliApp.ModSelectors;
namespace AET.ModVerifyTool.ModSelectors;

internal class ModSelectorFactory(IServiceProvider serviceProvider)
{
Expand Down
4 changes: 2 additions & 2 deletions src/ModVerify.CliApp/ModSelectors/SettingsBasedModSelector.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,16 @@
using System.Globalization;
using System.IO.Abstractions;
using System.Linq;
using AET.ModVerifyTool.Options;
using EawModinfo.Model;
using EawModinfo.Spec;
using Microsoft.Extensions.DependencyInjection;
using ModVerify.CliApp.Options;
using PG.StarWarsGame.Engine;
using PG.StarWarsGame.Infrastructure;
using PG.StarWarsGame.Infrastructure.Games;
using PG.StarWarsGame.Infrastructure.Services.Name;

namespace ModVerify.CliApp.ModSelectors;
namespace AET.ModVerifyTool.ModSelectors;

internal class SettingsBasedModSelector(IServiceProvider serviceProvider)
{
Expand Down
2 changes: 2 additions & 0 deletions src/ModVerify.CliApp/ModVerify.CliApp.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
<IsPackable>false</IsPackable>
<TargetFrameworks>net8.0;net48</TargetFrameworks>
<OutputType>Exe</OutputType>
<RootNamespace>AET.ModVerifyTool</RootNamespace>
<AssemblyName>ModVerify</AssemblyName>
<ApplicationIcon>$(RepoRootPath)aet.ico</ApplicationIcon>
<Title>AET.ModVerify.CommandLine</Title>
<Product>AET.ModVerify</Product>
Expand Down
6 changes: 3 additions & 3 deletions src/ModVerify.CliApp/ModVerifyApp.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@
using System.Threading.Tasks;
using AET.ModVerify;
using AET.ModVerify.Reporting;
using AET.ModVerifyTool.ModSelectors;
using AET.ModVerifyTool.Options;
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Logging;
using ModVerify.CliApp.ModSelectors;
using ModVerify.CliApp.Options;

namespace ModVerify.CliApp;
namespace AET.ModVerifyTool;

internal class ModVerifyApp(ModVerifyAppSettings settings, IServiceProvider services)
{
Expand Down
2 changes: 1 addition & 1 deletion src/ModVerify.CliApp/ModVerifyPipeline.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
using PG.StarWarsGame.Engine;
using PG.StarWarsGame.Engine.Database;

namespace ModVerify.CliApp;
namespace AET.ModVerifyTool;

internal class ModVerifyPipeline(
GameEngineType targetType,
Expand Down
2 changes: 1 addition & 1 deletion src/ModVerify.CliApp/Options/GameInstallationsSettings.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
using System.Diagnostics.CodeAnalysis;
using PG.StarWarsGame.Engine;

namespace ModVerify.CliApp.Options;
namespace AET.ModVerifyTool.Options;

internal record GameInstallationsSettings
{
Expand Down
4 changes: 2 additions & 2 deletions src/ModVerify.CliApp/Options/ModVerifyAppSettings.cs
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
using System;
using AET.ModVerify.Settings;
using System.Diagnostics.CodeAnalysis;
using AET.ModVerify.Settings;

namespace ModVerify.CliApp.Options;
namespace AET.ModVerifyTool.Options;

internal record ModVerifyAppSettings
{
Expand Down
2 changes: 1 addition & 1 deletion src/ModVerify.CliApp/Options/ModVerifyOptions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
using CommandLine;
using PG.StarWarsGame.Engine;

namespace ModVerify.CliApp.Options;
namespace AET.ModVerifyTool.Options;

internal class ModVerifyOptions
{
Expand Down
4 changes: 2 additions & 2 deletions src/ModVerify.CliApp/Program.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
using AET.ModVerify.Reporting.Reporters;
using AET.ModVerify.Reporting.Reporters.JSON;
using AET.ModVerify.Reporting.Reporters.Text;
using AET.ModVerifyTool.Options;
using AET.SteamAbstraction;
using AnakinRaW.CommonUtilities.Hashing;
using AnakinRaW.CommonUtilities.Registry;
Expand All @@ -15,7 +16,6 @@
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Logging;
using Microsoft.Extensions.Logging.Console;
using ModVerify.CliApp.Options;
using PG.Commons.Extensibility;
using PG.StarWarsGame.Engine;
using PG.StarWarsGame.Files.ALO;
Expand All @@ -30,7 +30,7 @@
using Serilog.Events;
using Serilog.Filters;

namespace ModVerify.CliApp;
namespace AET.ModVerifyTool;

internal class Program
{
Expand Down
4 changes: 2 additions & 2 deletions src/ModVerify.CliApp/SettingsBuilder.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
using System.IO.Abstractions;
using AET.ModVerify.Reporting;
using AET.ModVerify.Settings;
using AET.ModVerifyTool.Options;
using Microsoft.Extensions.DependencyInjection;
using ModVerify.CliApp.Options;

namespace ModVerify.CliApp;
namespace AET.ModVerifyTool;

internal class SettingsBuilder(IServiceProvider services)
{
Expand Down
2 changes: 1 addition & 1 deletion src/ModVerify.CliApp/VerifyGameInstallationData.cs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using System.Text;
using PG.StarWarsGame.Engine;

namespace ModVerify.CliApp;
namespace AET.ModVerifyTool;

internal class VerifyGameInstallationData
{
Expand Down
1 change: 1 addition & 0 deletions src/ModVerify/ModVerify.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<Description>Provides interfaces and classes to verify Empire at War / Forces of Corruption game modifications.</Description>
<PackageId>AlamoEngineTools.ModVerify</PackageId>
<RootNamespace>AET.ModVerify</RootNamespace>
<AssemblyName>AET.ModVerify</AssemblyName>
<PackageTags>alamo,petroglyph,glyphx</PackageTags>
</PropertyGroup>

Expand Down

0 comments on commit 596a01c

Please sign in to comment.