Skip to content

[WIP] Simplifications and stability corrections #188

[WIP] Simplifications and stability corrections

[WIP] Simplifications and stability corrections #188

Triggered via pull request January 10, 2025 10:14
Status Failure
Total duration 2m 51s
Artifacts

test.yml

on: pull_request
Matrix: Build & Test
Fit to window
Zoom out
Zoom in

Annotations

3 errors and 21 warnings
Build & Test (ubuntu-latest)
Process completed with exit code 1.
Build & Test (ubuntu-latest)
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Build & Test (ubuntu-latest): test/PG.StarWarsGame.Infrastructure.Testing/Game/Installation/GameInstallation.cs#L88
Possible null reference argument for parameter 'path' in 'IDirectoryInfo IDirectory.CreateDirectory(string path)'.
Build & Test (ubuntu-latest): test/PG.StarWarsGame.Infrastructure.Test/Clients/Arguments/NamedArgumentTest.cs#L98
The type 'uint?' cannot be used as type parameter 'T' in the generic type or method 'NamedArgument<T>'. Nullability of type argument 'uint?' doesn't match 'notnull' constraint.
Build & Test (ubuntu-latest): test/PG.StarWarsGame.Infrastructure.Test/Clients/Processes/GameProcessTest.cs#L188
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Build & Test (ubuntu-latest): test/PG.StarWarsGame.Infrastructure.Test/PetroglyphGameInfrastructureIntegrationTest.cs#L325
Possible null reference argument for parameter 'obj' in 'int ModIdentityEqualityComparer.GetHashCode(IModIdentity obj)'.
Build & Test (ubuntu-latest): test/PG.StarWarsGame.Infrastructure.Test/GameServices/Detection/CompositeDetectorTest.cs#L260
The event 'CompositeDetectorTest.EmptyDetector.InitializationRequested' is never used
Build & Test (ubuntu-latest): test/PG.StarWarsGame.Infrastructure.Test/Clients/Arguments/ArgumentCollectionTest.cs#L16
Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)
Build & Test (ubuntu-latest): test/PG.StarWarsGame.Infrastructure.Test/Clients/Arguments/ArgumentCollectionTest.cs#L27
Do not use Assert.Equal() to check for collection size. Use Assert.Single instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)
Build & Test (ubuntu-latest): test/AET.SteamAbstraction.Test/Vdf/VValueFacts.cs#L16
Dereference of a possibly null reference.
Build & Test (ubuntu-latest): test/AET.SteamAbstraction.Test/Vdf/VValueFacts.cs#L18
Dereference of a possibly null reference.
Build & Test (ubuntu-latest): test/AET.SteamAbstraction.Test/Vdf/VPropertyFacts.cs#L19
Dereference of a possibly null reference.
Build & Test (windows-latest): test/PG.StarWarsGame.Infrastructure.Testing/Game/Installation/GameInstallation.cs#L88
Possible null reference argument for parameter 'path' in 'IDirectoryInfo IDirectory.CreateDirectory(string path)'.
Build & Test (windows-latest): test/PG.StarWarsGame.Infrastructure.Test/Clients/Arguments/NamedArgumentTest.cs#L98
The type 'uint?' cannot be used as type parameter 'T' in the generic type or method 'NamedArgument<T>'. Nullability of type argument 'uint?' doesn't match 'notnull' constraint.
Build & Test (windows-latest): test/PG.StarWarsGame.Infrastructure.Test/Clients/Processes/GameProcessTest.cs#L188
This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
Build & Test (windows-latest): test/PG.StarWarsGame.Infrastructure.Test/PetroglyphGameInfrastructureIntegrationTest.cs#L325
Possible null reference argument for parameter 'obj' in 'int ModIdentityEqualityComparer.GetHashCode(IModIdentity obj)'.
Build & Test (windows-latest): test/PG.StarWarsGame.Infrastructure.Test/GameServices/Detection/CompositeDetectorTest.cs#L260
The event 'CompositeDetectorTest.EmptyDetector.InitializationRequested' is never used
Build & Test (windows-latest): test/PG.StarWarsGame.Infrastructure.Test/Clients/Arguments/ArgumentCollectionTest.cs#L16
Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)
Build & Test (windows-latest): test/PG.StarWarsGame.Infrastructure.Test/Clients/Arguments/ArgumentCollectionTest.cs#L27
Do not use Assert.Equal() to check for collection size. Use Assert.Single instead. (https://xunit.net/xunit.analyzers/rules/xUnit2013)
Build & Test (windows-latest): test/AET.SteamAbstraction.Test/Vdf/VValueFacts.cs#L16
Dereference of a possibly null reference.