Run tests on Windows and Ubuntu with Github Actions #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gruenwaldlk
reviewed
Jan 29, 2021
| env: | ||
| Solution_Name: eawx-build.sln # Replace with your solution name, i.e. MyWpfApp.sln. | ||
| Test_Project_Path: eawx-build-test/eawx-build-test.csproj # Replace with the path to your test project, i.e. MyWpfApp.Tests\MyWpfApp.Tests.csproj. | ||
| ACTIONS_ALLOW_UNSECURE_COMMANDS: true |
There was a problem hiding this comment.
In the PetroglyphTools repository, the ACTIONS_ALLOW_UNSECURE_COMMANDS: true is not needed.
That could be down to the setup though (all dotnet, and no specific versions for the actions and 3.1.x for dotnet core)
| - name: Setup .NET Core SDK | ||
| uses: actions/[email protected] | ||
| with: | ||
| dotnet-version: 3.1.101 |
There was a problem hiding this comment.
Maybe use 3.1.x instead so it automatically uses the latest 3.1 version.
|
|
||
| - name: Setup .NET Core SDK | ||
| uses: actions/[email protected] |
There was a problem hiding this comment.
Is there a need for the specific version, otherwise you could just use actions/setup-dotnet@v1
| @@ -85,4 +84,34 @@ jobs: | |||
| run: msbuild $env:Solution_Name /t:Restore /p:Configuration=$env:Configuration | |||
There was a problem hiding this comment.
Is there a specific reason to run via msbuild and not dotnet build?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should solve issue #142