-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature chat app #345
base: master
Are you sure you want to change the base?
Feature chat app #345
Conversation
❌ Deploy Preview for delightful-daifuku-a9f6ea failed. Why did it fail? →
|
@sadath2001 any updates on this PR? |
hi @AlfiyaSiddique , i have already raised this PR. been more than a week. |
ok i see there are merge conflicts |
@AlfiyaSiddique , kindly review |
What i actually mean by this was, i will raise another PR, apart from this. (since we discussed that we can create 2 PR's for this) https://drive.google.com/file/d/17VSOzIsUSNPUIdU57UCwtWR3Gc8RhAR6/view?usp=sharing (demo) |
@sadath2001 there are random unknown characters in some files, due to improper merge conflicts resolution: Can you just check all changed files and remove such lines? |
Also, I will complete the review for this by Friday as I am a bit occupied |
Hi, sure I will resolve them, i apologise. |
Sure, take your time please. |
@sadath2001 any updates on this: |
@sadath2001 can you complete this PR before tomorrow eve? |
@sadath2001 just to remind you that the points will not be counted if the pr will merge after 7 |
|
What does this PR do?
Added chat functionality using sockets
Displays last time of the messages (eg: 1 hour ago etc)
Displays user avatar as well to distinguish messages
Fixes #2
@AlfiyaSiddique , kindly review
https://drive.google.com/file/d/1hPuEonRq0Jq0Q7km4txaLOX11oc2y8To/view?usp=sharing
How should this be tested?
Checklist
Required
console.logs