-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: reduce project.json duplication and split prepublish #2658
base: main
Are you sure you want to change the base?
Conversation
View your CI Pipeline Execution ↗ for commit bd00a83.
☁️ Nx Cloud last updated this comment at |
ee20a1a
to
06e17db
Compare
packages/@o3r/core/project.json
Outdated
}, | ||
"prepare-build-builders": {}, | ||
"build-builders": {}, | ||
"lint": {}, | ||
"test": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"test": { | |
"test": {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, for a mysterious reason, it is mandatory in few packages (including this one).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems that you had to add the executor for all the packages that have a test
script in the package.json
this could be the mysterious reason, or just a coincidence
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea, not sure neither why having the script in the package.json
would have any impact here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why but I confirm that if you remove the test
script in package.json
you don't have to specify the executor
you can see when running yarn nx show project core --web
that there is only one target test
that appears either on npm scripts
or others
depending if you have a script with the name test
or not in package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm interesting, let's remove the test
script then.
They are not really used
packages/@o3r/design/project.json
Outdated
}, | ||
"prepare-build-builders": {}, | ||
"build-builders": {}, | ||
"lint": {}, | ||
"test": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"test": { | |
"test": {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, for a mysterious reason, it is mandatory in few packages (including this one).
packages/@o3r/pipeline/project.json
Outdated
}, | ||
"prepare-build-builders": {}, | ||
"build-builders": {}, | ||
"lint": {}, | ||
"test": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"test": { | |
"test": {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, for a mysterious reason, it is mandatory in few packages (including this one).
}, | ||
"prepare-build-builders": {}, | ||
"build-builders": {}, | ||
"lint": {}, | ||
"test": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"test": { | |
"test": {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, for a mysterious reason, it is mandatory in few packages (including this one).
packages/@o3r/styling/project.json
Outdated
}, | ||
"prepare-build-builders": {}, | ||
"build-builders": {}, | ||
"lint": {}, | ||
"test": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"test": { | |
"test": {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, for a mysterious reason, it is mandatory in few packages (including this one).
packages/@o3r/workspace/project.json
Outdated
"lint": { | ||
"executor": "nx:run-commands" | ||
}, | ||
"lint": {}, | ||
"test": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"test": { | |
"test": {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, for a mysterious reason, it is mandatory in few packages (including this one).
29ce3df
to
3e07761
Compare
7216b6a
to
1f5f72d
Compare
1f5f72d
to
6c50eb6
Compare
@@ -16,15 +16,14 @@ | |||
"build:tools": "yarn nx run-many --target=build --projects=eslint-plugin,workspace", | |||
"build:lint": "yarn nx run-many --target=build --projects=eslint-plugin", | |||
"build:swagger-gen": "yarn nx run-many --target=build-swagger", | |||
"prepare:publish": "yarn prepare-publish \"$(yarn workspaces:list)\" --append dist", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The goal of this task was to fix #112, is this no longer applicable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is still valid on Nx 19 (4s per prepare-publish task) but it is greatly reduced in Nx 20 (< 200ms).
ebe2519
to
1871ddf
Compare
chore: split npm prepublish task
1871ddf
to
bd00a83
Compare
Proposed change
chore: reduce project.json duplication
chore: split npm prepublish task
Related issues
- No issue associated -