fix(gnews): fixed prepare_gnews_url function #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @AndyTheFactory, I hope you're doing well! Could you kindly take a look at this? It’s quite important for my work. I’d really appreciate your help! |
fasihhussain00
changed the title
|
Unfortunately looks like the repo isn't maintained anymore. Can't wait for newspaper5k 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Reason:
The
prepare_gnews_urlfunction in the google_news.py file was causing a crash due to an AttributeError. Specifically, the error message observed was:AttributeError: 'NoneType' object has no attribute 'groupdict'This occurred while attempting to access
primary_url = match.groupdict()["primary_url"]which failed because match was None at the time of execution.Found out google has changed something and code wasn't able to decode the url.
Proposed Solution
Found a package google-news-url-decoder used it, it basically does an HTTP get request to get the url.
How did you test it?
I ran the specific tests related to this change. The tests were previously failing due to the error, but after the fix, they passed without any modification to the test cases.
Notes for the reviewer
I ran into a problem with the Python version compatibility. I was able to resolve the issue by setting the minimum Python version to 3.9.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.