ci(release): release next from a dedicated branch and restore requireCommits - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adopt the branch-bound npm release channels introduced in the org reusable workflows (AntelopeJS/.github#10):
latestis released only from the default branch andnextonly from a branch namednext. The reusable workflow now passes--git.requireBranch=<branch>to release-it, so the repository config no longer hardcodes it..github/workflows/release.yml: pinrelease-npm-public.ymltof4ce81591d09d271a480fd796e12a725cc973e0f(channel input, secrets and permissions unchanged)..release-it.json: removegit.requireBranch(supplied by the workflow);git.requireCommitsstaystrue.CONTRIBUTING.md: add a short "Releases" section pointing to the organization-wide release channels guide.Same change as AntelopeJS/antelopejs#155 and AntelopeJS/api#52.
Related issue
Follow-up of AntelopeJS/.github#10.
Verification
pnpm lint,pnpm knip,pnpm test(77 passing),pnpm test:package: pass.pnpm format:check: fails onCHANGELOG.mdonly, which this PR does not touch (pre-existing, file last changed bychore(release): v0.1.0).pnpm exec release-it --ci --dry-run --no-npm.publish --git.requireBranch=ci/next-branch-releases --no-git.requireUpstream: config parses and the dry run completes (0.1.0 → 0.1.1); the local version bump was reverted.--no-git.requireUpstreamwas only needed because the local branch had no upstream yet.--git.requireBranch=nextfails withMust be on branch next, as expected.actionlintis not available locally; the workflow change is a single SHA update.Checklist