UI config now primarily pulled from backend endpoint #4273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaTP
previously approved these changes
Jan 30, 2024
jsenko
added a commit
to jsenko/apicurio-registry
that referenced
this pull request
Feb 1, 2024
jsenko
added a commit
that referenced
this pull request
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have introduced a new REST API endpoint to return the UI config:
/system/uiConfigThe response payload is a JSON document containing all of the UI config (except the Registry v3 endpoint for obvious reasons).
The UI now only needs to be configured with the v3 endpoint. It will then fetch the baseline config from the above system endpoint. All config can now be set on the backend pod/container via env variables. A few new env vars have been introduced to help with this.
All config can be overridden using env vars in the UI pod/container. The UI will merge the config from the endpoint with the local overrides to form the final config.