Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for automatically generating SemVer branches #5000

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Support for automatically generating SemVer branches #5000

merged 3 commits into from
Aug 9, 2024

Conversation

EricWittmann
Copy link
Member

No description provided.

@EricWittmann EricWittmann mentioned this pull request Aug 8, 2024
Closed
@EricWittmann EricWittmann requested a review from jsenko August 8, 2024 18:56
jsenko
jsenko approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@jsenko jsenko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm just surprised that you reverted the database handle nesting. Was that intentional?

@EricWittmann EricWittmann merged commit 82b076a into main Aug 9, 2024
20 checks passed
@EricWittmann EricWittmann deleted the feat/semantic-versioning branch August 9, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsenko jsenko jsenko approved these changes

Assignees
No one assigned
Labels
area/storage area/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EricWittmann @jsenko