Repository navigation
Conversation
Previous review (2026-11-09)Automated review note — AI-generated (Claude+Codex), validated against the live diff. Please sanity-check before acting. Reviewed at head WMM2025 model, altitude/date inputs and track interpolation check out (coefficients match NOAA, field values match pygeomag); two nonblocking items remain. Should fix
Minor
|
c343cea to
24b5876
Compare
Previous review (2026-11-09)Automated review note — AI-generated (Claude+Codex), validated against the live diff. Please sanity-check before acting. Reviewed at head The WMM2025 model still matches the published coefficients (all 90 coefficients identical, and field values agree with pygeomag), but both items from the last review are still open. Since then, only the Location tooltip changed (the 2025-2030 validity note); there was no code change and no reply. Should fix
Minor (1)
Not fully reviewed: no end-to-end browser run with real logs, so on-page rendering and long-log performance are untested. |
… GPS without instances
With Use position along flight, the compass yaw uses the declination at each sample and the field length plot shows the expected field along the track.
24b5876 to
1e389b5
Compare
Previous review (2026-11-09)Automated review note — AI-generated (Claude+Codex), validated against the live diff. Please sanity-check before acting. Reviewed at head Both items from the last review are fixed and the rest of the change still checks out. One optional plot nit remains. Since 24b5876 the branch was rebased to 1e389b5. Yaw now uses the declination along the flight track, and the field-length plot follows the track's field strength, so a perfect compass on a 60N 110W to 100W route no longer shows 8° of false drift. A blank altitude now means sea level, and the log date is also read from GPS logs without instances. Minor (1)
Not fully reviewed: there was no browser run with real logs, so plot rendering and long-log performance are untested. |
|
Automated review note — AI-generated (Claude+Codex), validated against the live diff. Please sanity-check before acting. Reviewed at head No open issues remain at 9ad8c7c. The change looks ready to merge. Since 1e389b5 there is one new commit. It extends the expected field-length line to the whole log, held at the track end values (MAGFit/magfit.js:420). That fixes the last minor item: the line now matches what the fit uses, and compass samples from before the first GPS fix have a reference line. Not fully reviewed: performance on multi-hour logs and a real long-range flight were not tested, only a short real log and synthetic routes. |
"Use position throughout flight rather than just using a single origin" from #81. Built on #373 (its commit is included), so that should go first.
When the log has
POS, the earth field is evaluated along the track (at most one point per second, skipping 0,0 before a fix) and interpolated to each attitude/compass sample time for the body frame expected field. A "Use position along flight" checkbox in the Location box controls this. It is ticked by default when there is a track and disabled when there is none. The single Location is still used for intensity and declination in the plots, and when the box is unticked.With the WMM the field changes by roughly 1 mGauss per 10 km and 7 to 10 mGauss per 100 km (1.4 to 1.7%) at the locations I checked, so this mainly matters for long range flights. On two short logs, fitted offsets move by about 0.005 mGauss. With the box unticked, results are identical to #373, and the interpolated field matches direct evaluation at the track points.