Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add move bookmark toolbar to bottom right... #723

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

edeso
Copy link

@edeso edeso commented Dec 22, 2024

overlaying browser content translucently to save space

@Aris-t2
Copy link
Owner

Aris-t2 commented Dec 24, 2024

Hi, I don't think this is the best way to add such a feature. Please use the discussion thread to talk about "new features" instead of commiting to main files directly.

Test this. That way you will keep the top toolbar, which you can hide with default browser toolbar context menu.

#navigator-toolbox {
  z-index: 3 !important;
}

#PlacesToolbar {
  opacity: 0.01 !important;
  z-index: 1000 !important;
  position: fixed !important;
  right: 0 !important;
  bottom: 0 !important;
  width: 50vw !important;
  border-top: unset !important;
}

/* set visibility 100% on mouse over */
#PlacesToolbar:hover {
  opacity: 1 !important;
  background: var(--general_toolbar_color_navbar, inherit) !important;
}

@edeso
Copy link
Author

edeso commented Dec 24, 2024

Hi, I don't think this is the best way to add such a feature. Please use the discussion thread to talk about "new features" instead of commiting to main files directly.

no problem. using a variant of this and thought to maybe contribute it. don't want to make a big thing of it.
thanks for your efforts all these years btw.!

Test this. That way you will keep the top toolbar, which you can hide with default browser toolbar context menu.

ok, why? my code hides the toolbar fine just as well. what is the difference?

i see you are using #PlacesToolbar why is that?

#navigator-toolbox {
  z-index: 3 !important;
}

#PlacesToolbar {
  opacity: 0.01 !important;

that makes it virtually invisible. not my intention. want to be aware that it is there but able to read through it.

will try it with a raised opacity s.b. though.

@edeso
Copy link
Author

edeso commented Dec 24, 2024

Test this. That way you will keep the top toolbar, which you can hide with default browser toolbar context menu.

#navigator-toolbox {
  z-index: 3 !important;
}

#PlacesToolbar {
  opacity: 0.01 !important;
  z-index: 1000 !important;
  position: fixed !important;
  right: 0 !important;
  bottom: 0 !important;
  width: 50vw !important;
  border-top: unset !important;
}

/* set visibility 100% on mouse over */
#PlacesToolbar:hover {
  opacity: 1 !important;
  background: var(--general_toolbar_color_navbar, inherit) !important;
}

works the same. less rules though, so i'll stick with it. Thanks!

question: why is width: 50vw needed?

@Aris-t2
Copy link
Owner

Aris-t2 commented Dec 25, 2024

Some width value is needed or the bookmarks might extend beyond the visible area of the window, because #PlacesToolbar is a hbox element.
Other values like 100% can of course be used too.

@edeso
Copy link
Author

edeso commented Dec 25, 2024

ic thx!

what's the reason that #PlacesToolbar should be used instead of #PersonalToolbar ?

@edeso
Copy link
Author

edeso commented Dec 25, 2024

hmm, weird. after a restart of firefox 133.0.3 the toolbar now sticks below the navbar on top with the styles from above in userChrome.css

using the modified addonbar_move-... script on the othe rhand still works fine.

any idea?

@Aris-t2
Copy link
Owner

Aris-t2 commented Dec 27, 2024

#PlacesToolbar only contains bookmarks. #PersonalToolbar contains everything incl. #PlacesToolbar. Using the code like this keeps the top toolbar for e.g. buttons.

I just realized hiding bookmarks toolbar also makes bookmarks inaccessible, so keep using your code, if you do not need the additional top toolbar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants