Merge pull request #43 from ZZZank/12.x/forge

Fix vignette config

src/main/java/me/jellysquid/mods/sodium/client/gui/SodiumGameOptionPages.java

@@ -15,6 +15,8 @@
 import net.minecraft.client.Minecraft;
 import net.minecraft.util.text.ITextComponent;
 import net.minecraft.util.text.TextComponentTranslation;
+import net.minecraftforge.client.GuiIngameForge;
+
 import org.lwjgl.opengl.Display;
 
 import java.util.ArrayList;

src/main/java/me/jellysquid/mods/sodium/mixin/features/options/MixinInGameHud.java

@@ -1,15 +1,24 @@
 package me.jellysquid.mods.sodium.mixin.features.options;
 
 import me.jellysquid.mods.sodium.client.SodiumClientMod;
-import net.minecraft.client.gui.GuiIngame;
+import net.minecraftforge.client.GuiIngameForge;
+
 import org.spongepowered.asm.mixin.Mixin;
 import org.spongepowered.asm.mixin.injection.At;
 import org.spongepowered.asm.mixin.injection.Redirect;
 
-@Mixin(GuiIngame.class)
+/**
+ * note that both {@link net.minecraft.client.gui.GuiIngame} and {@link net.minecraftforge.client.GuiIngameForge}
+ * implements client GUI rendering, and mixins for GuiIngame can be totally useless since GuiIngame might be
+ * intentionally ignored and barely invoked
+ */
+@Mixin(GuiIngameForge.class)
 public class MixinInGameHud {
     @Redirect(method = "renderGameOverlay", at = @At(value = "INVOKE", target = "Lnet/minecraft/client/Minecraft;isFancyGraphicsEnabled()Z"))
-    private boolean redirectFancyGraphicsVignette() {
+    private boolean vintagium$redirectVignette() {
+        //mixin target is `if (renderVignette && Minecraft.isFancyGraphicsEnabled())`
+        //we assume that `renderVignette` is always true, because vanilla/forge will not change its value, and mods that
+        //will change it explicitly must have a reason.
         return SodiumClientMod.options().quality.enableVignette;
     }
 }