-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edge-to-edge dialog support #3414
Open
geekygecko
wants to merge
8
commits into
task/android-15
Choose a base branch
from
task/edge-to-edge-dialog
base: task/android-15
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+125
−185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
|
geekygecko
commented
Jan 8, 2025
@@ -197,6 +197,7 @@ | |||
<item name="isDark">false</item> | |||
<item name="isImageTintEnabled">false</item> | |||
<item name="imageTintThemeCacheTag">light</item> | |||
<item name="enableEdgeToEdge">true</item> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The BottomSheetDialog
material component uses this to know it should draw to the edge which fixes the navigation bar being a different colour to the background.
geekygecko
force-pushed
the
task/android-15
branch
from
January 10, 2025 00:47
48057e8
to
0f2a182
Compare
geekygecko
force-pushed
the
task/edge-to-edge-dialog
branch
from
January 10, 2025 00:59
4af81bf
to
af41c16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request aims to improve the dialog styling. Switching to Android 15 caused issues with the padding and colours, especially regarding the navigation bar.
The latest version might look worse on the older SDK 30 and 24 but it look a lot better on the higher SDKs when using the dialog. The content that slides behind the navigation bar handle isn't a solid navigation bar colour. For example before the change:
Screen.Recording.2025-01-10.at.3.18.06.pm.mov
After:
Screen.Recording.2025-01-10.at.3.19.26.pm.mov
This change took a while, so it doesn't take even longer I haven't focused on the landscape version. I will do that in a future PR if we have time to spend on it.
Testing Instructions
Try different bottom sheet dialogs in the app. And verify the content is displayed correctly with the navigation bar.
Screenshots
Filter sort by dialog
After
Before (main)
Podcast grid options dialog
After
Before (main)
Clear Up Next dialog
After
Before (main)
User file dialog
After
Before (main)
Pocket Casts champion
After
Player - Long press next episode
Before (main)
Player - Playback effects
The extra bottom padding will go once we remove the old custom playback speed settings.
Before (main)
Player - Sleep timers
Before (main)
Checklist
./gradlew spotlessApply
to automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xml
I have tested any UI changes...