Tracks Audit: Add missing bookmark events #3420
Open
+88
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing Instructions
Bookmark - Episode view
🔵 Tracked: bookmark_edit_form_shown
🔵 Tracked: bookmark_edit_form_dismissed,
🔵 Tracked: bookmark_edit_form_submitted
🔵 Tracked: bookmark_share_tapped
🔵 Tracked: bookmark_delete_form_shown
🔵 Tracked: bookmark_delete_form_submitted
Bookmark - Profile
no bookmarks found
view🔵 Tracked: bookmarks_clear_search_tapped
🔵 Tracked: bookmarks_searchbar_clear_button_tapped
🔵 Tracked: bookmark_share_tapped
🔵 Tracked: bookmark_delete_form_shown
🔵 Tracked: bookmark_delete_form_submitted
Checklist
If this is a user-facing change, I have added an entry in CHANGELOG.md./gradlew spotlessApply
to automatically apply formatting/linting)I have considered whether it makes sense to add tests for my changesAll strings that need to be localized are inmodules/services/localization/src/main/res/values/strings.xml
Any jetpack compose components I added or changed are covered by compose previews