Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracks Audit: Add missing bookmark events #3420

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mebarbosa
Copy link
Contributor

Description

  • This adds some missing events for Bookmark

Testing Instructions

Bookmark - Episode view

  1. Log with plus / patron account
  2. Go to a podcast, follow and play an episode
  3. Open shelf and tap on Bookmark
  4. Ensure 🔵 Tracked: bookmark_edit_form_shown
  5. Dismiss this form
  6. Ensure 🔵 Tracked: bookmark_edit_form_dismissed,
  7. Back to the screen and tap to save the bookmark
  8. Ensure 🔵 Tracked: bookmark_edit_form_submitted
  9. In Now Playing screen, switch to bookmark tab
  10. Long press the bookmark
  11. Tap to share
  12. Ensure 🔵 Tracked: bookmark_share_tapped
  13. Close the screen
  14. Tap to dele the bookmark
  15. Ensure 🔵 Tracked: bookmark_delete_form_shown
  16. Delete
  17. Ensure 🔵 Tracked: bookmark_delete_form_submitted

Bookmark - Profile

  1. Have some bookmarks
  2. Go to Profile -> Bookmarks
  3. Search something like "sdfsdf" to see the no bookmarks found view
  4. Tap on Clear Search
  5. Ensure 🔵 Tracked: bookmarks_clear_search_tapped
  6. Search something again
  7. Tap on X searchbar clear button
  8. Ensure 🔵 Tracked: bookmarks_searchbar_clear_button_tapped
  9. Long press the bookmark
  10. Tap to share
  11. Ensure 🔵 Tracked: bookmark_share_tapped
  12. Close the screen
  13. Tap to dele the bookmark
  14. Ensure 🔵 Tracked: bookmark_delete_form_shown
  15. Delete
  16. Ensure 🔵 Tracked: bookmark_delete_form_submitted

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@mebarbosa mebarbosa added this to the 7.81 milestone Jan 9, 2025
@mebarbosa mebarbosa requested a review from a team as a code owner January 9, 2025 13:44
@mebarbosa mebarbosa requested review from geekygecko and removed request for a team January 9, 2025 13:44
@dangermattic
Copy link
Collaborator

1 Error
🚫 PR requires a [Type] label and either a [Area] or [Project] label.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Jan 9, 2025

📲 You can test the changes from this Pull Request in 📱 Mobile by scanning the QR code below to install the corresponding build.
App Name 📱 Mobile
Build TypedebugProd
Commit9940fdc
Direct Downloadpocketcasts-app-prototype-build-pr3420-9940fdc.apk
📲 You can test the changes from this Pull Request in 🚗 Automotive by scanning the QR code below to install the corresponding build.
App Name 🚗 Automotive
Build TypedebugProd
Commit9940fdc
Direct Downloadpocketcasts-automotive-prototype-build-pr3420-9940fdc.apk
📲 You can test the changes from this Pull Request in ⌚ Wear by scanning the QR code below to install the corresponding build.
App Name ⌚ Wear
Build TypedebugProd
Commit9940fdc
Direct Downloadpocketcasts-wear-prototype-build-pr3420-9940fdc.apk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants