fix: release sdist to PyPI #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frostming the Python CI did not pass. Could you please take another look? |
Signed-off-by: Frost Ming <[email protected]>
Updated |
Signed-off-by: Frost Ming <[email protected]>
Signed-off-by: Frost Ming <[email protected]>
Signed-off-by: Frost Ming <[email protected]>
Signed-off-by: Frost Ming <[email protected]>
jiahansu
pushed a commit
to WiseSync/OpenCC
that referenced
this pull request
Aug 21, 2024
* fix: release sdist to PyPI * fix: add newline at file end * fix: ignore more files Signed-off-by: Frost Ming <[email protected]> * fix: change the install root of cmake Signed-off-by: Frost Ming <[email protected]> * fix: make it work for editable build as well Signed-off-by: Frost Ming <[email protected]> * fix release script Signed-off-by: Frost Ming <[email protected]> * fix: include files in sdist Signed-off-by: Frost Ming <[email protected]> --------- Signed-off-by: Frost Ming <[email protected]> Co-authored-by: Carbo Kuo <[email protected]>
jiahansu
pushed a commit
to WiseSync/OpenCC
that referenced
this pull request
Aug 21, 2024
* fix: release sdist to PyPI * fix: add newline at file end * fix: ignore more files Signed-off-by: Frost Ming <[email protected]> * fix: change the install root of cmake Signed-off-by: Frost Ming <[email protected]> * fix: make it work for editable build as well Signed-off-by: Frost Ming <[email protected]> * fix release script Signed-off-by: Frost Ming <[email protected]> * fix: include files in sdist Signed-off-by: Frost Ming <[email protected]> --------- Signed-off-by: Frost Ming <[email protected]> Co-authored-by: Carbo Kuo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #701
Also change to not invoke
setup.pyfor build and install in favor of PEP 517