Skip to content

Commit

Permalink
better logs for chromedriver
Browse files Browse the repository at this point in the history
  • Loading branch information
ahmednfwela committed Nov 25, 2024
1 parent 4ab0370 commit 47e2ded
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 3 deletions.
14 changes: 13 additions & 1 deletion .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -172,10 +172,22 @@ jobs:
uses: ./.github/actions/integration_test_base
- name: Run Chromedriver
uses: nanasess/setup-chromedriver@v2
- run: chromedriver --port=4444 --trace-buffer-size=100000 & sleep 5
- run: chromedriver --verbose --port=4444 --trace-buffer-size=100000 | tee chromedriver.log & sleep 5
name: run chrome driver
- name: Run Web Integration Tests
run: melos run integration_test:chrome
# for reference: https://github.com/firebase/flutterfire/blob/d41e30a808b47458d7ebd402862bcd55d8563ccb/.github/workflows/e2e_tests.yaml#L281-L289
- name: Ensure all tests are actually passing
run: |
# We have to check the output for failed tests matching the string "[E]"
output=$(<output.log)
if [[ "$output" =~ \[E\] ]]; then
# You will see "All tests passed." in the logs even when tests failed.
echo "All tests did not pass. Please check the logs for more information."
exit 1
fi
shell: bash

# web has no test coverage for now
# - name: Upload Coverage Report
# uses: actions/upload-artifact@v4
Expand Down
2 changes: 1 addition & 1 deletion melos.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ scripts:
- ios
integration_test:chrome:
name: Flutter Chrome Integration tests
exec: flutter drive -v --profile --driver=test_driver/integration_test.dart --target=integration_test/app_test.dart -d web-server --browser-name=chrome # optional: --web-port=8080
exec: flutter drive --profile --driver=test_driver/integration_test.dart --target=integration_test/app_test.dart -d web-server --browser-name=chrome | tee output.log
packageFilters:
flutter: true
dirExists:
Expand Down
1 change: 0 additions & 1 deletion packages/oidc/example/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ google_secrets.dart
/build/

# Web related
lib/generated_plugin_registrant.dart

# Symbolication related
app.*.symbols
Expand Down

0 comments on commit 47e2ded

Please sign in to comment.