Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

05-interactive-rating-respoisve #138

Closed
wants to merge 14 commits into from

Conversation

jjf2009
Copy link
Contributor

@jjf2009 jjf2009 commented Oct 6, 2024

#26
05-interactive-rating project is made responsive and also fixed bug where if the user submited the form without choosing any number is would take it was 4
Screenshot
Screen Shot 2024-10-06 at 17 11 42
Screen Shot 2024-10-06 at 17 11 46

Kindly label this PR with gssoc-ext and hactobter and level
Also label the PR that have been merged of mine please

Copy link

netlify bot commented Oct 6, 2024

Deploy Preview for openfrontendmentor ready!

Name Link
🔨 Latest commit 81da965
🔍 Latest deploy log https://app.netlify.com/sites/openfrontendmentor/deploys/67048fff43ae09000874afdc
😎 Deploy Preview https://deploy-preview-138--openfrontendmentor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jjf2009
Copy link
Contributor Author

jjf2009 commented Oct 7, 2024

@AkshitGarg24 kindly add labels to this pr

@AkshitGarg24
Copy link
Collaborator

@jjf2009, resolve conflicts, and update the branch.

@jjf2009
Copy link
Contributor Author

jjf2009 commented Oct 7, 2024

@AkshitGarg24 conflicts are resloved add labels for this pr

@AkshitGarg24
Copy link
Collaborator

@jjf2009, this is the deployed link of the project after merging the PR : Link.
Compare it with the original website as it is making a lot of changes in the original website. Are you sure about the changes in the PR?

@jjf2009
Copy link
Contributor Author

jjf2009 commented Oct 7, 2024

@AkshitGarg24 ok i will check

@jjf2009
Copy link
Contributor Author

jjf2009 commented Oct 7, 2024

@AkshitGarg24 please check again i have fixed it on my side i have also added some git actions for greeting and auto labeling the issues with gssoc-ext and hacktober .

@AkshitGarg24
Copy link
Collaborator

AkshitGarg24 commented Oct 7, 2024

Why have you deleted Code_of_Conduct.md file. And please do only those changes that are assigned to you as there are many contributors who wants to or might be working on the same issue. This program is not only to solve the issues of the project, but also its an opportunity for many contributors who are new in the field of open-source and wants to explore this field.

@AkshitGarg24
Copy link
Collaborator

@beRajeevKumar can you please have a look on this PR?

@jjf2009
Copy link
Contributor Author

jjf2009 commented Oct 7, 2024

@AkshitGarg24 i have removed the changes that was not assigned to me and have added the code of conduct md . Very sorry for my conduct

@AkshitGarg24
Copy link
Collaborator

Hey @jjf2009, no issues at all!! Take it easy. You haven't done anything wrong. Don't be sorry for this. Let @beRajeevKumar have a look at this PR. We will merge it soon. Till then, you can work on other issues.

@beRajeevKumar
Copy link
Collaborator

Please make some meaningful contributions that really impact the project and your skill set.

Copy link
Collaborator

@beRajeevKumar beRajeevKumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had close this PR

@jjf2009 jjf2009 deleted the RatingReposive branch October 25, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants