Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile fixes #325

Merged
merged 2 commits into from
Jul 23, 2013
Merged

Makefile fixes #325

merged 2 commits into from
Jul 23, 2013

Conversation

postmodern
Copy link
Contributor

  • Fixed a typo in uninstall where a .svg wasn't being `rm -f'ed.
  • Install into /usr/local by default, but allow the PREFIX variable to be overridden.

@ghost
Copy link

ghost commented Jul 23, 2013

Is installing to /usr/local by default recommended?

@postmodern
Copy link
Contributor Author

/usr is reserved for software installed by the package manager, /usr/local is reserved for software installed by the system administrator. So your rpm/deb/etc specs should continue to install into /usr, but make install should definitely install into /usr/local. See the FHS for more info.

@ghost
Copy link

ghost commented Jul 23, 2013

Since debian/rules and RPM spec just call make install how can the system tell the difference between an installation from a package and a manual make install?

@postmodern
Copy link
Contributor Author

For debian/rules I have seen this done:

override_dh_auto_test-indep:

override_dh_auto_build-indep:

%:
  PREFIX=/usr dh $@

I would consult a second opinion on debian packaging etiquette, since another developer submitted the above code to one of my projects.

For rpm/*.spec I do this:

%install
make install PREFIX=%{buildroot}/usr

Atheros1 pushed a commit that referenced this pull request Jul 23, 2013
@Atheros1 Atheros1 merged commit 833bafb into Bitmessage:master Jul 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants