Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BSD fixes #236: Initial github issue templates #296

Merged
merged 4 commits into from
Sep 18, 2024

Conversation

mejiaj
Copy link
Collaborator

@mejiaj mejiaj commented Sep 6, 2024

Initial bug and feature request template

@mejiaj mejiaj linked an issue Sep 6, 2024 that may be closed by this pull request
---
name: Bug report
about: Create a report to help us improve
title: 'bixal-site-drupal - bug: '
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: BSD a better fit here? It's a standard convention for commits and branch names.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an interesting question. I definitely think it's good to add bug in the issue title and in the labels (we should totally add a feature request label too for your below template) for visibility. But putting the site name in the title of every issue might take up a lot of real estate when both the submitter and the reviewer of the issue know where they are already. I would say BSD or not needed.

Copy link
Collaborator

@mattsqd mattsqd Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should totally add a feature request label too for your below template

Ah, this already exists, it's enhancement

Copy link
Collaborator Author

@mejiaj mejiaj Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattsqd thanks for the feedback. Added the enhancement label in 8b47d16.

The site label might be useful as we're maintaining multiple GitHub projects. You can quickly distinguish which repo it's coming from. Shall I remove that for this initial version of the PR?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattsqd thanks for the feedback. Added the enhancement label in 8b47d16.

The site label might be useful as we're maintaining multiple GitHub projects. You can quickly distinguish which repo it's coming from. Shall I remove that for this initial version of the PR?

I see, that makes sense. Feel free to leave as is and we can see how it works and go from there!

@mejiaj mejiaj requested a review from mattsqd September 9, 2024 13:58
@mattsqd mattsqd merged commit 40e13c4 into develop Sep 18, 2024
2 checks passed
@mejiaj mejiaj deleted the feature/BSD-236-issue-templates branch October 9, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create GitHub issue and feature templates
2 participants