Add mirrors support for URL SCMs #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comes in handy if the file should be addressed relative to the user home directory.
The validator must also return the validated data which might actually have been mangled.
No change in functionality intended.
Instead of relying on the invoker class to catch the OSError, handle it directly and show a proper error message.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #546 +/- ##
==========================================
- Coverage 88.38% 88.27% -0.12%
==========================================
Files 46 46
Lines 14543 14669 +126
==========================================
+ Hits 12854 12949 +95
- Misses 1689 1720 +31 ☔ View full report in Codecov by Sentry. |
Add the 'preMirror' and 'fallbackMirror' keywords to the user configuration. SCMs can hook into these keywords to get their mirror settings.
Iterate about all possible URLs when trying to download. The pre- and fallback-mirror URLs will only be included if the SCM is deterministic, though.
If a file was downloaded and matching mirrors have their 'upload' attribute set to "true", upload the file to all such mirrors after the integrity has been verified.
Instead of just returning the port as context manager object, return a class with some statistics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #360