builder: consider all execution paths #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The commit message looks somehow incomplete? |
|
🤦 Thanks for noticing. Apparently I was a bit distracted yesterday evening. 😆 |
The builds step implicitly depends on the execution path of all dependencies. So far we only tracked arguments. But some build systems also store the absolute path to tools. In this case, the build will fail if a tool path changes. The simple approach by using getAllDepSteps() will additionally add the sandbox path too. This will lead to rebuilds if the sandbox image changes. This should not happen too often and is probably not even a bad idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The builds step implicitly depends on the execution path of all dependencies, even for tools.