scripts: set cmd line color mode immediately #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user gives a color mode on the command line, apply the mode immediately. Otherwise the mode was not applied until some recipes layer was successfully parsed. Because error messages are already colored, that created some inconsistent behaviour. Fixes BobBuildTool#578.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #581 +/- ##
==========================================
- Coverage 88.67% 88.66% -0.01%
==========================================
Files 46 46
Lines 14856 14857 +1
==========================================
Hits 13173 13173
- Misses 1683 1684 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user gives a color mode on the command line, apply the mode immediately. Otherwise the mode was not applied until some recipes layer was successfully parsed. Because error messages are already colored, that created some inconsistent behaviour.
Fixes #578.