Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic git refs #602

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Generic git refs #602

merged 3 commits into from
Dec 10, 2024

Conversation

jkloetzke
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 94.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 88.84%. Comparing base (ee29e75) to head (d53691c).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
pym/bob/scm/git.py 94.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #602   +/-   ##
=======================================
  Coverage   88.84%   88.84%           
=======================================
  Files          48       48           
  Lines       15415    15460   +45     
=======================================
+ Hits        13695    13736   +41     
- Misses       1720     1724    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

So far, Bob could only handle branches (refs/heads/...), tags
(refs/tags/...) and plain commits. But Git allows other "refs" (git
references) as well. One example is Gerrit where changes can be
downloaded as /refs/changes/... refs.

A generic ref is handled like a tag. It is checked out once and the
workspace will be in detached head state. Bob will not expect the ref to
change its targeted commit by default. In case the ref does change, the
user can enable the "rebase" property.

Fixes BobBuildTool#601.
@sixtyfourktec
Copy link

sixtyfourktec commented Dec 10, 2024

I tried this with a gerrit change of the form refs/changes/50/19450/17 and it worked like a charm ;)

@jkloetzke jkloetzke merged commit e794980 into BobBuildTool:master Dec 10, 2024
11 checks passed
@jkloetzke jkloetzke deleted the generic-git-refs branch December 10, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants