Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CI for dso-r #10

Merged
merged 30 commits into from
Oct 18, 2024
Merged

Enable CI for dso-r #10

merged 30 commits into from
Oct 18, 2024

Conversation

grst
Copy link
Collaborator

@grst grst commented Sep 30, 2024

Close #1.

Adds the following CI services

  • automatically run roxygen and pre-commit
  • run tests (R CMD check)
  • on release, check that the git tag matches the version specified in DESCRIPTION and build a tarball with R CMD build

I don't think we need a separate docs page (pkgdown) for this repo for now, I'd rather include the R-specific documentation in the main docs (sphinx) as well.

@grst grst requested review from tschwarzl and DSchreyer and removed request for tschwarzl September 30, 2024 13:24
@grst
Copy link
Collaborator Author

grst commented Sep 30, 2024

@DSchreyer, R CMD check currently fails because of a WARNING related to "S3 generic/method consistency"
image

Could you look into that please?

There's also a NOTE about

 checking whether the namespace can be loaded with stated dependencies ... NOTE
  Warning: no function found corresponding to methods exports from ‘dso’ for: ‘show’

that sounds relevant, but I really don't know if it really matters.

@grst
Copy link
Collaborator Author

grst commented Oct 18, 2024

btw, due to some github limitations, CI does not run after a pre-commit autoformat has been pushed.

To avoid this setup pre-commit locally (pre-commit install).

If it happens nonetheless, you can push an empty commit to trigger CI:

git commit --allow-empty -m "trigger CI"

Copy link
Collaborator

@DSchreyer DSchreyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested and works as expected

@DSchreyer DSchreyer merged commit 1b7a290 into main Oct 18, 2024
5 checks passed
@DSchreyer DSchreyer deleted the CI branch October 18, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable CI
2 participants