Few minor improvements for Waterfox Current #1213

hawkeye116477 · 2019-10-19T10:26:31Z

Langpacks are from http://ftp.mozilla.org/pub/firefox/releases/68.1.0esr/linux-x86_64/xpi/ and little modified by me (changed Firefox to Waterfox, etc => hawkeye116477/LanguagePacksForWaterfox@957efac). For langpacks we may need maybe some makefile to put them in correct dir, I tried to add them in browser/features, but if they are on that dir, seems not working, however they work in browser/extensions, but are disabled and can't be enabled until I switch extensions.autoDisableScopes to 3.

I also added Unity/Global Menu support made by Canonical/Ubuntu Mozilla Team (https://bazaar.launchpad.net/~mozillateam/firefox/firefox.xenial/view/1347/debian/patches/unity-menubar.patch) and path to the running binary to about:support.

…lod,jaws

Thanks for Ubuntu Mozilla Team 😄

grahamperrin · 2019-10-19T13:27:15Z

Is the intention here to bundle (include) language packs?

If #1055 (comment) bugging about:preferences can be fixed, then I reckon it'll be better/simpler to have language packs on demand.

(Recent releases of Firefox take a very smart, effective approach. Quite unlike things as they were a few years ago.)

BrowserWorks#1211

Fix BrowserWorks#1210

hawkeye116477 · 2019-10-19T14:55:43Z

@grahamperrin Maybe, just like for Classic.
If #1055 (comment) bugging about:preferences can be fixed, then I reckon it'll be better/simpler to have language packs on demand.
Putting link to AMO might be not the best thing, cuz some strings needs to be changed for Waterfox.
Better probably will be to put them on some own addons store (Addons.Waterfox.Net)/Waterfox's site. For Classic similar thing couldn't be done with provided update url on manifest? As I remember that was some time ago and then it came bundled.

* Restart button in PanelUI and Menu * Copy current tab URL * Copy all tab URLs

hawkeye116477 · 2019-10-23T15:18:04Z

Small update:
Similarly as for Classic (#1203 (comment)), but prefs are on other place. I also hidden default not translated „Restart (developer)" menu item and replaced it with new which also has optional restart confirmation dialog. But maybe restart menu icon needs some improvement.

laniakea64 · 2019-10-24T15:29:05Z

Hi @hawkeye116477 , do these new browser.restart.* prefs apply to all restarts of Waterfox, or only when using the restart menu items added by this PR? If the latter, would it be possible to rename the prefs (maybe to browser.restart_menu.*) and clarify the about:preferences labels to avoid confusion?

hawkeye116477 · 2019-10-24T15:46:56Z

@laniakea64 That prefs applies only to restart menu items, similarly as it was on Cyberfox.

would it be possible to rename the prefs (maybe to browser.restart_menu.*) and clarify the about:preferences labels to avoid confusion?
Ok, I'll change that later.

Peacock365 · 2019-10-24T21:18:14Z

Hey hawkeye116477,

would it be possible to also reinstate the Pop-ups section Cyberfox had? I mean the pop-up, graphics, and javascript settings you can see here:

https://i.computer-bild.de/imgs/4/9/0/7/8/6/2/Screenshot-7-Cyberfox-642x576-5a6b663220ecccae.jpg

After all, the about:config settings dom.popup_allowed_events (for pop-up windows - EDIT: unnecessary to restore this one, still exists under about:preferences#privacy, that leaves just graphics and Javascript), javascript.enabled (for javascript), and permissions.default.image (for graphics) still exist, so it shouldn't be hard to bring those settings back.

You would be an absolute hero if something like that were doable for you.

hawkeye116477 · 2019-10-25T16:52:12Z

@laniakea64 Changed

@Peacock365 I'l look into that later.

MrAlex94 · 2019-10-28T22:16:25Z

Right, so Mozilla have been testing bundling different languages at build time the same way they do the default locale. I’m going to figure out how to do that because the language packs inflate the binaries size by huge amounts when pre compressed.

https://firefox-source-docs.mozilla.org/build/buildsystem/locales.html

hawkeye116477 · 2019-10-29T22:13:42Z

@MrAlex94 Isn't better to just put langpacks separately from application on some addon store, just like Pale Moon team did?

Anyway, you can accept this PR, all should be good 😄.

@Peacock365

Peacock365 · 2019-10-30T09:31:34Z

@hawkeye116477 Fantastic work!

hawkeye116477 · 2019-11-03T18:11:30Z

Small preview what I done:

If I want to also move some settings to another categories, make more categories, mainly move from general to another categories, little like on Vivaldi, should I do that in current preferences or make „new order" toggleable just like on Classic?

Recommendations doesn't work currently, so disable it

grahamperrin · 2019-11-11T06:21:30Z

Remove annoying message about private browsing on addons page

From the commit, I can't visualise the message. Can you provide a screenshot?

Thanks.

hawkeye116477 · 2019-11-11T09:48:30Z

@grahamperrin Set extensions.htmlaboutaddons.enabled to false and you'll see that message.

grahamperrin · 2019-11-11T12:26:30Z

The purple indicators?

It's important to not lose those completely.

hawkeye116477 · 2019-11-11T12:37:22Z

@grahamperrin Not purple, I mean that message „Waterfox Current is changing...".

grahamperrin · 2019-11-11T17:53:44Z

If that's removed, then what's left to educate the user?

In Firefox 70.0.1, a click on a purple icon of privacy refers to e.g.:

https://support.mozilla.org/1/firefox/70.0.1/FreeBSD/en-GB/extensions-pb

– which redirects to:

https://support.mozilla.org/en-US/kb/extensions-private-browsing?as=u&utm_source=inproduct

hawkeye116477 · 2019-11-11T18:06:16Z

@grahamperrin @Peacock365 requested, so I removed, but users will manage 😄
There is also inactive link to add-ons supports.
Maybe I'l look to that later and restore that links, which currently refer to nothing.

Peacock365 · 2019-11-11T18:06:28Z

Uhm, @grahamperrin, this silly notification takes up a whole lot of screen real estate. This is unacceptable in about:addons, which is meant to be a rather compact overview of your add-ons. Also, the new HTML about:addons page doesn't display this notification, either. It's also unacceptable to have that notification there for the entirety of the next year. When you click on an add-on, you can choose whether to enable it in private browsing windows or not, the switch is rather self-explanatory as well.

MrAlex94

I'm weary about adding this change - which is why I didn't do it in the first place. brandShortName is used quite often throughout the codebase, and I don't know how this might break users browser space. It has happened before where branding changes have messed things up, so this will need extensive testing.

I didn't approve of all changes.

hawkeye116477 · 2019-11-12T08:42:51Z

@MrAlex94 So should I revert 46ac944? Anyway without that change - on Linux is icon mish mash (#1211), there is also not distinctive title on Profile Manager (#1247).

this will need extensive testing.
Isn't that the next generation of Waterfox for testing?

Is there something another except this change which you didn't approve?

MrAlex94 · 2019-11-12T17:52:52Z

Is there something another except this change which you didn't approve?

Not yet, but I need to test each change thoroughly. It's taking a while because there are a lot of changes here.

hawkeye116477 · 2019-11-12T18:04:23Z

I'd say not that a lot, only a lot code. Anyway, ok.

MrAlex94 · 2019-11-12T18:06:01Z

Well, it becomes a lot when testing each change on every platform :-) plus I’ve been busy with the website so it isn’t going as fast as it could. Appreciate the work though, won’t be long now.

…

On Tue, 12 Nov 2019 at 18:04, hawkeye116477 ***@***.***> wrote: I'd say not that a lot, only a lot code. Anyway, ok. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1213>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABECQWH54Y2U7E3C76TEPJTQTLV2TANCNFSM4JCPGHYA> .

browser/components/preferences/in-content-all-new/webpages.js

grahamperrin · 2019-11-16T18:15:58Z

… this silly notification takes up a whole lot of screen real estate …

Agreed re: the use of space, which is why I drew attention to the sensible Firefox behaviour in response to clicks on the small purple icons.

MrAlex94 · 2019-11-19T22:21:03Z

Okay, have been testing and all seems well. Will pull in a bit.

MrAlex94 · 2019-11-20T11:59:37Z

browser/components/customizableui/content/panelUI.js

+            document.getElementById("appMenu-restart-button").hidden = false;
+          }
+        } catch (e) {
+          throw new Error("We're sorry but something has gone wrong with 'browser.restart_menu.showpanelmenubtn'" + e);


This error keeps getting thrown when accessing the hamburger menu on macOS. Tested with both restart button enabled/disabled.

JavaScript error: chrome://browser/content/customizableui/panelUI.js, line 286: Error: We're sorry but something has gone wrong with 'browser.restart_menu.showpanelmenubtn'TypeError: document.getElementById(...) is null

Ah, I see the problem, I added appMenu-restart-button inside of condition #ifndef XP_MACOSX, so it's not available for Mac.

Cool, thanks for the fix.

MrAlex94 · 2019-11-20T16:08:53Z

Since I used most of the commits here (but not all), I git cherry-pick'ed the commits and then pushed them to the current branch. It doesn't look like GitHub knows how to handle partial commit pulls.

Peacock365 · 2019-11-20T20:53:15Z

@hawkeye116477 @MrAlex94

I've noticed that, when one of the australized themes (curved tabs) is used, the new tab button in tab bar is squared, I suppose this is not intended to be so, since the new tab button behind the tabs was rounded in Waterfox 68b1... Please fix this cosmetic issue.

hawkeye116477 · 2019-11-24T18:32:54Z

@MrAlex94 In case of 2ba3e02, if you wanted FF-like behaviour, then browser.statusbar.mode should be set to 1, cuz 0 disables showing any status.

Peacock365 · 2019-12-02T09:28:25Z

Kind reminder that the "new tab button cosmetic issue" still is not fixed.

[current] Fixes to commits related to PR #1213

hawkeye116477 added 3 commits October 19, 2019 10:53

Bug 1555366: Add the path to the running binary to about:support. r=f…

01719d7

…lod,jaws

Add langpacks

12b5c80

Add Unity/Global Menu support

605c798

Thanks for Ubuntu Mozilla Team 😄

hawkeye116477 added 3 commits October 19, 2019 16:20

Fix icon mish mash

46ac944

BrowserWorks#1211

Allow to run Waterfox Classic when Current is running

8830225

Fix BrowserWorks#1210

Update langpacks

e92f885

grahamperrin mentioned this pull request Oct 19, 2019

Waterfox Classic using the icon for Current; elsewhere, Waterfox Current using the icon for Classic #1211

Closed

hawkeye116477 added 2 commits October 23, 2019 09:47

Port several useful features from Cyberfox

57c4e1a

* Restart button in PanelUI and Menu * Copy current tab URL * Copy all tab URLs

Update langpacks

9b808de

This comment has been minimized.

Sign in to view

hawkeye116477 mentioned this pull request Oct 25, 2019

[current] Cleanup prefs for "Recommend (extensions/features) as you browse" #1223

Merged

hawkeye116477 added 2 commits October 25, 2019 18:37

Rename restart prefs and move to new header

ffeed34

Update langpacks

a845764

hawkeye116477 force-pushed the current branch from 3b74b11 to a845764 Compare October 25, 2019 16:49

hawkeye116477 added 3 commits October 29, 2019 17:18

Add prefs for loading images automatically and enabling JS

091fbf6

Add exceptions for scripts

4362360

Update langpacks

de202ec

Peacock365 mentioned this pull request Oct 30, 2019

Few minor improvements for Waterfox Classic #1203

Merged

Port some new privacy and new tab settings from Cyberfox

8195c52

laniakea64 mentioned this pull request Nov 10, 2019

Waterfox Current: Expose extensions.getAddons.showPane in about:config by default #1192

Closed

Fix BrowserWorks#1192

dc9cd76

Recommendations doesn't work currently, so disable it

hawkeye116477 force-pushed the current branch from fa27e2d to dc9cd76 Compare November 10, 2019 21:36

MrAlex94 reviewed Nov 11, 2019

View reviewed changes

MrAlex94 previously approved these changes Nov 11, 2019

View reviewed changes

Fix initial Tab Bar position

8f3e5fc

MrAlex94 reviewed Nov 15, 2019

View reviewed changes

browser/components/preferences/in-content-all-new/webpages.js Outdated Show resolved Hide resolved

Fix All-new preferences

4d9c105

MrAlex94 reviewed Nov 20, 2019

View reviewed changes

laniakea64 mentioned this pull request Dec 9, 2019

[current] Fixes to commits related to PR #1213 #1293

Merged

MrAlex94 added a commit that referenced this pull request Dec 10, 2019

Merge pull request #1293 from laniakea64/1213

5a6139f

[current] Fixes to commits related to PR #1213

hawkeye116477 closed this Dec 19, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Few minor improvements for Waterfox Current #1213

Few minor improvements for Waterfox Current #1213

hawkeye116477 commented Oct 19, 2019 •

edited

Loading

grahamperrin commented Oct 19, 2019 •

edited

Loading

hawkeye116477 commented Oct 19, 2019 •

edited

Loading

hawkeye116477 commented Oct 23, 2019 •

edited

Loading

This comment has been minimized.

laniakea64 commented Oct 24, 2019

hawkeye116477 commented Oct 24, 2019 •

edited

Loading

Peacock365 commented Oct 24, 2019 •

edited

Loading

hawkeye116477 commented Oct 25, 2019 •

edited

Loading

MrAlex94 commented Oct 28, 2019

hawkeye116477 commented Oct 29, 2019 •

edited

Loading

Peacock365 commented Oct 30, 2019

hawkeye116477 commented Nov 3, 2019 •

edited

Loading

grahamperrin commented Nov 11, 2019

hawkeye116477 commented Nov 11, 2019

grahamperrin commented Nov 11, 2019

hawkeye116477 commented Nov 11, 2019 •

edited

Loading

grahamperrin commented Nov 11, 2019

hawkeye116477 commented Nov 11, 2019 •

edited

Loading

Peacock365 commented Nov 11, 2019 •

edited

Loading

MrAlex94 left a comment •

edited

Loading

hawkeye116477 commented Nov 12, 2019 •

edited

Loading

MrAlex94 commented Nov 12, 2019

hawkeye116477 commented Nov 12, 2019

MrAlex94 commented Nov 12, 2019 via email

grahamperrin commented Nov 16, 2019

MrAlex94 commented Nov 19, 2019

MrAlex94 Nov 20, 2019

hawkeye116477 Nov 20, 2019 •

edited

Loading

MrAlex94 Nov 20, 2019

MrAlex94 commented Nov 20, 2019 •

edited

Loading

Peacock365 commented Nov 20, 2019

hawkeye116477 commented Nov 24, 2019

Peacock365 commented Dec 2, 2019

Few minor improvements for Waterfox Current #1213

Few minor improvements for Waterfox Current #1213

Conversation

hawkeye116477 commented Oct 19, 2019 • edited Loading

grahamperrin commented Oct 19, 2019 • edited Loading

hawkeye116477 commented Oct 19, 2019 • edited Loading

hawkeye116477 commented Oct 23, 2019 • edited Loading

This comment has been minimized.

laniakea64 commented Oct 24, 2019

hawkeye116477 commented Oct 24, 2019 • edited Loading

Peacock365 commented Oct 24, 2019 • edited Loading

hawkeye116477 commented Oct 25, 2019 • edited Loading

MrAlex94 commented Oct 28, 2019

hawkeye116477 commented Oct 29, 2019 • edited Loading

Peacock365 commented Oct 30, 2019

hawkeye116477 commented Nov 3, 2019 • edited Loading

grahamperrin commented Nov 11, 2019

hawkeye116477 commented Nov 11, 2019

grahamperrin commented Nov 11, 2019

hawkeye116477 commented Nov 11, 2019 • edited Loading

grahamperrin commented Nov 11, 2019

hawkeye116477 commented Nov 11, 2019 • edited Loading

Peacock365 commented Nov 11, 2019 • edited Loading

MrAlex94 left a comment • edited Loading

Choose a reason for hiding this comment

hawkeye116477 commented Nov 12, 2019 • edited Loading

MrAlex94 commented Nov 12, 2019

hawkeye116477 commented Nov 12, 2019

MrAlex94 commented Nov 12, 2019 via email

grahamperrin commented Nov 16, 2019

MrAlex94 commented Nov 19, 2019

MrAlex94 Nov 20, 2019

Choose a reason for hiding this comment

hawkeye116477 Nov 20, 2019 • edited Loading

Choose a reason for hiding this comment

MrAlex94 Nov 20, 2019

Choose a reason for hiding this comment

MrAlex94 commented Nov 20, 2019 • edited Loading

Peacock365 commented Nov 20, 2019

hawkeye116477 commented Nov 24, 2019

Peacock365 commented Dec 2, 2019

hawkeye116477 commented Oct 19, 2019 •

edited

Loading

grahamperrin commented Oct 19, 2019 •

edited

Loading

hawkeye116477 commented Oct 19, 2019 •

edited

Loading

hawkeye116477 commented Oct 23, 2019 •

edited

Loading

hawkeye116477 commented Oct 24, 2019 •

edited

Loading

Peacock365 commented Oct 24, 2019 •

edited

Loading

hawkeye116477 commented Oct 25, 2019 •

edited

Loading

hawkeye116477 commented Oct 29, 2019 •

edited

Loading

hawkeye116477 commented Nov 3, 2019 •

edited

Loading

hawkeye116477 commented Nov 11, 2019 •

edited

Loading

hawkeye116477 commented Nov 11, 2019 •

edited

Loading

Peacock365 commented Nov 11, 2019 •

edited

Loading

MrAlex94 left a comment •

edited

Loading

hawkeye116477 commented Nov 12, 2019 •

edited

Loading

hawkeye116477 Nov 20, 2019 •

edited

Loading

MrAlex94 commented Nov 20, 2019 •

edited

Loading