Add our wayland compatible screenlocker #636
Conversation
There was a problem hiding this comment.
My only bit of feedback would be to make sure we add swayidle and wlopm as dependencies in our meson.build. While technically they are runtime dependencies, it is still a good way to make sure the packager has acknowledged that they are required.
I have cloned, built gtk-session-lock + gtklock, installed wlopm and swayidle, and updated my power / idle settings to lock on screen blanking. Set it to 1 minute for testing and it worked, then changed it to 3 minutes and it correctly updated to the new value.
Upon blanking, gtklock fired up as one would hope, showing a block on my "second" monitor with a prompt on my first. Likely it was the inverse but regardless, no funny business with locking anymore which is absolutely freaking fantastic.
Logged in and while clearly there is some work I need to do on the daemon side to re-force displays to be positioned when they pop back up, your implementation worked perfectly!
fossfreedom
force-pushed
the
screenlock
branch
from
058ef30 to
f059394
Compare
as discussed - new build option to check for runtime dependencies |
JoshStrobl
force-pushed
the
screenlock
branch
from
8fd2547 to
81cf9de
Compare
This is to aid packagers/developers where there are apps that are needed to successfully run budgie-desktop. For the final packaging, distros can switch off this check to speed up build-time i.e. limit the number of additional dependencies these packages would bring in.
JoshStrobl
force-pushed
the
screenlock
branch
from
81cf9de to
e91bbe7
Compare
…and switch to using dbus rather than systemctl for suspend
Description
This PR is another "low hanging fruit" - this replaces budgie-screensaver / gnome-screensaver with a wayland compatible screenlocker.
It wires up the various screenlock settings in BCC.
At the same time it wires up the power control settings in BCC to suspend on battery / ac if idle
The how;
it uses swayidle as our idle controller
it uses either gtklock or swaylock for the lockscreen
it uses wlopm to control screen blanking
it uses systemctl to suspend
it uses upower GLIB library to determine battery/ac states.
The power dialog lock button previously was linked to the screensaver lock function - this now has been reorientated to a new dbus entry to perform the same function.
Most definitely this really needs a good testing effort since there are lots of combinations that can be achieved.
gtklock is basically vanilla, but we support distros to either style (gtklock.css) and/or add a config (gtklock.ini) in the DATA for CONFIG budgie-desktop folder (/usr/share/budgie-desktop/ or /etc/budgie-desktop/)
I haven't wired up the BCC "dim" control - this should perhaps be part of Josh's v2 daemon since it needs calling via a wayland client to control the screen brightness.
Submitter Checklist
git rebase -i(if needed)