Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

209 new build #250

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

209 new build #250

wants to merge 10 commits into from

Conversation

anton-seaice
Copy link
Contributor

Draft of new versions for #209

@anton-seaice
Copy link
Contributor Author

@chrisb13 - we can add the MOM version to this branch too. It doesn't build yet. There is some more to chase down in CESM_share still

(It gives this mysterious error:

 >> 547    /g/data/tm70/as2285/spack0.22/environments/x/access-om3-nuopc/share/CESM_share/src/shr_reprosum_mod.F90:453: undefined reference to `t_barrierf_'
     548    share/libOM3_share.a(shr_reprosum_mod.F90.o): In function `shr_reprosum_mod_mp_shr_reprosum_calc_':
  >> 549    /g/data/tm70/as2285/spack0.22/environments/x/access-om3-nuopc/share/CESM_share/src/shr_reprosum_mod.F90:453: undefined reference to `t_barrierf_'
     550    share/libOM3_share.a(shr_reprosum_mod.F90.o): In function `shr_reprosum_mod_mp_shr_reprosum_calc_':
  >> 551    /g/data/tm70/as2285/spack0.22/environments/x/access-om3-nuopc/share/CESM_share/src/shr_reprosum_mod.F90:453: undefined reference to `t_barrierf_'

)

@anton-seaice
Copy link
Contributor Author

If ESCOMP/CESM_share#58 gets merged we can remove the #ifdef TIMING patch again.

@anton-seaice
Copy link
Contributor Author

If ESCOMP/WW3#33 gets merged we can remove the ifdef W3_IC4 patch too

@anton-seaice
Copy link
Contributor Author

I also asked about the wrong variable name in CDEPS here

I moved a newer CDEPS because it's sets a default value for a namelist parameter we don't set, (ESCOMP/CDEPS#315)

@anton-seaice anton-seaice force-pushed the 209-new-build branch 3 times, most recently from 660e4d6 to 038cc27 Compare December 13, 2024 02:59
anton-seaice
anton-seaice commented Dec 20, 2024
View reviewed changes
MOM6/CMakeLists.txt Outdated
MOM6/src/core/MOM_dynamics_split_RK2b.F90
MOM6/src/equation_of_state/MOM_EOS_base_type.F90
MOM6/src/parameterizations/lateral/MOM_self_attr_load.F90

extra_sources/mom_cap_gtracer_flux.F90
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisb13 - I think extra_sources should go in our mom6 branch also ?

Copy link
Contributor

@chrisb13 chrisb13 Jan 6, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, now added here.

Note that I didn't bother updating my build branch here as I think you are building elsewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can update this branch - we can tidy up the commits before merging if needed and then try a redeploy here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, now running.

anton-seaice and others added 4 commits December 20, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisb13 chrisb13 chrisb13 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@chrisb13 chrisb13

@anton-seaice anton-seaice

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anton-seaice @chrisb13