Ensure standard in is always redirected when there is input #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 20, 2024 23:26
Increases test coverage by introducing dedicated Windows and Linux/Unix/MacOs test suites. Uses the NUnit "Platform" attribute to ensure only the relevant tests are run on a given OS. The unit tests are run across all 3 OS' in the GitHub Actions workflow, so every test will get run, even if code authors don't have access to one of the OS'.
Previously standard in was only being opened when there were argument
or environment variables. If there was a value in the "Input" parameter,
but no arguments or environment variables, an exception was thrown about
stanard input not being redirected. This made it impossible to write
code like
cli {
Exec "cat"
Input "foo"
}
To pipe data to a program on stdin.
|
Hi @AP-Hunt,
I didn't even know, that this attribute exist, so I think it's an improvement. I'll create a new release in the next days, I hope it's ok?! 🙂 |
|
Yeah not a problem at all. No rush from me. |
|
This fix has been released in Fli v1.111.1 and is already available at Nuget. Thank you, appreciate your work! 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70
Previously standard in was only being opened when there were argument or environment variables. If there was a value in the "Input" parameter, but no arguments or environment variables, an exception was thrown about standard input not being redirected. This made it impossible to write code like below to pipe data to a program on stdin.
The first commit on the branch increases test coverage for Linux and Mac OS X by creating separate sets of tests for them, and uses NUnit's
Platformattribute to ensure only the relevant tests are run on a given OS.I would be happy to drop the first commit if that's not something you want.