Repository navigation
fix: reject non-string values in emulate extraHttpHeaders - #3486
Open
zichen0116 wants to merge 1 commit into
Open
zichen0116 wants to merge 1 commit into
zichen0116 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3455.
emulateaccepted non-stringextraHttpHeadersvalues (numbers, booleans, nested objects):headerStringTransformonly checked that the parsed JSON was an object and then cast it toRecord<string, string>, so the values flowed intopage.setExtraHTTPHeaders, which expects strings.This change validates each header value in
headerStringTransform, mirroring the existingwsHeaderscheck insrc/config/browser-options.ts: a non-string value now fails validation withHeader "<key>" must have a string value. String maps, empty string (clears headers), and the non-object error are unchanged.Tests: added schema-level tests in
tests/tools/emulation.test.tscovering number, boolean, and nested-object values (fail) and an all-string map (pass). Verified locally:tests/tools/emulation.test.ts45/45 pass, including the 4 new tests;tests/McpServer.test.tsandtests/McpPage.test.tsmock-based tests pass (the only failures there are real-browser tests that need a downloaded Chrome binary, unavailable in this environment).