Repository navigation
fix(browser): suggest custom profiles for missing port files - #3496
Open
AmarGhugare wants to merge 1 commit into
Open
AmarGhugare wants to merge 1 commit into
AmarGhugare wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #889.
When channel-based auto-connect cannot find the default profile's DevToolsActivePort file, suggest
--user-data-dirfor a custom profile. Keep the existing running-browser/remote-debugging guidance and the original error cause.Only add the hint for a missing-file (ENOENT) cause. Puppeteer uses the same outer message for malformed port files and refused connections, where changing the profile would be misleading. Permission failures also keep their existing behavior; those are covered separately by #3487. The README guidance for #889 was already updated in #3386.
Validation on Windows, Node 24.19.0, Chrome 157.0.8103.78:
npm run test -- tests/browser.test.ts: 41 passed.npm run format: passed.npm run test: 1,985 passed, 5 skipped, zero failures.