Skip to content

Commit

Permalink
Handle Grace period exceptions that are applied at the 1p level
Browse files Browse the repository at this point in the history
Bug: b/382264360
Change-Id: Ie61254dba7feb6a08ffefcf063e99766d58f5ddc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6148734
Auto-Submit: Shuran Huang <[email protected]>
Reviewed-by: Wolfgang Beyer <[email protected]>
Commit-Queue: Shuran Huang <[email protected]>
  • Loading branch information
shuranhuang authored and Devtools-frontend LUCI CQ committed Jan 8, 2025
1 parent 16fdc4d commit e4b72f6
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion front_end/panels/security/CookieReportView.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import type * as Common from '../../core/common/common.js';
import * as Common from '../../core/common/common.js';
import * as i18n from '../../core/i18n/i18n.js';
import * as SDK from '../../core/sdk/sdk.js';
import * as Protocol from '../../generated/protocol.js';
Expand Down Expand Up @@ -451,8 +451,11 @@ export class CookieReportView extends UI.Widget.VBox {
})}`;
}
case Protocol.Audits.InsightType.GracePeriod: {
const url = SDK.TargetManager.TargetManager.instance().primaryPageTarget()?.inspectedURL();
const gracePeriodLink = UI.XLink.XLink.create(
'https://developers.google.com/privacy-sandbox/cookies/dashboard?url=' +
// The order of the URLs matters - needs to be 1P + 3P.
(url ? Common.ParsedURL.ParsedURL.fromString(url)?.host + '+' : '') +
(domain.charAt(0) === '.' ? domain.substring(1) : domain),
i18nString(UIStrings.reportedIssues), undefined, undefined, 'compatibility-lookup-link');

Expand Down

0 comments on commit e4b72f6

Please sign in to comment.