Legacy CSS Removal: Icons import Script - setup default/onerror place…

…holder image
CityOfBoston · Oct 27, 2021 · 49a3c6e · 49a3c6e
1 parent d072773
commit 49a3c6e
Show file tree

Hide file tree

Showing 17 changed files with 62 additions and 8 deletions.
diff --git a/components/icons/accessboston/accessboston.config.yml b/components/icons/accessboston/accessboston.config.yml
@@ -2,6 +2,7 @@ title: "accessboston"
 handle: "accessboston"
 status: "ready"
 context:
+  defaultIcon: "https://www.boston.gov/modules/custom/bos_content/modules/node_post/default_news.svg"
   icons:
     - file: "2_tickets.svg"
     - file: "Phire.svg"

diff --git a/components/icons/accessboston/accessboston.hbs b/components/icons/accessboston/accessboston.hbs
@@ -7,7 +7,12 @@
         </div>
 
         <div class="ex ex-i">
-          <img src="{{imgUrl "https://assets.boston.gov/icons/accessboston" icon.file}}" />
+          <img
+            alt="{{filename_to_string icon.file}}"
+            title="{{filename_to_string icon.file}}"
+            src="{{imgUrl "https://assets.boston.gov/icons/accessboston" icon.file}}"
+            onerror={{imgOnError}}
+          />
         </div>
 
         <div class="p-a300 t--sans">

diff --git a/components/icons/circle_icons/circle_icons.config.yml b/components/icons/circle_icons/circle_icons.config.yml
@@ -2,6 +2,7 @@ title: "circle icons"
 handle: "circle_icons"
 status: "ready"
 context:
+  defaultIcon: "https://www.boston.gov/modules/custom/bos_content/modules/node_post/default_news.svg"
   icons:
     - file: "2_tickets.svg"
     - file: "accessibility.svg"

diff --git a/components/icons/circle_icons/circle_icons.hbs b/components/icons/circle_icons/circle_icons.hbs
@@ -7,7 +7,12 @@
         </div>
 
         <div class="ex ex-i">
-          <img src="{{imgUrl "https://assets.boston.gov/icons/circle_icons" icon.file}}" />
+          <img
+            alt="{{filename_to_string icon.file}}"
+            title="{{filename_to_string icon.file}}"
+            src="{{imgUrl "https://assets.boston.gov/icons/circle_icons" icon.file}}"
+            onerror={{imgOnError}}
+          />
         </div>
 
         <div class="p-a300 t--sans">

diff --git a/components/icons/dept_icons/dept_icons.config.yml b/components/icons/dept_icons/dept_icons.config.yml
@@ -2,6 +2,7 @@ title: "dept icons"
 handle: "dept_icons"
 status: "ready"
 context:
+  defaultIcon: "https://www.boston.gov/modules/custom/bos_content/modules/node_post/default_news.svg"
   icons:
     - file: "age_strong.svg"
     - file: "age_strong_black.svg"

diff --git a/components/icons/dept_icons/dept_icons.hbs b/components/icons/dept_icons/dept_icons.hbs
@@ -7,7 +7,12 @@
         </div>
 
         <div class="ex ex-i">
-          <img src="{{imgUrl "https://assets.boston.gov/icons/dept_icons" icon.file}}" />
+          <img
+            alt="{{filename_to_string icon.file}}"
+            title="{{filename_to_string icon.file}}"
+            src="{{imgUrl "https://assets.boston.gov/icons/dept_icons" icon.file}}"
+            onerror={{imgOnError}}
+          />
         </div>
 
         <div class="p-a300 t--sans">

diff --git a/components/icons/drupal/drupal.config.yml b/components/icons/drupal/drupal.config.yml
@@ -2,6 +2,7 @@ title: "drupal"
 handle: "drupal"
 status: "ready"
 context:
+  defaultIcon: "https://www.boston.gov/modules/custom/bos_content/modules/node_post/default_news.svg"
   icons:
     - file: "archive.svg"
     - file: "delete.svg"

diff --git a/components/icons/drupal/drupal.hbs b/components/icons/drupal/drupal.hbs
@@ -7,7 +7,12 @@
         </div>
 
         <div class="ex ex-i">
-          <img src="{{imgUrl "https://assets.boston.gov/icons/drupal" icon.file}}" />
+          <img
+            alt="{{filename_to_string icon.file}}"
+            title="{{filename_to_string icon.file}}"
+            src="{{imgUrl "https://assets.boston.gov/icons/drupal" icon.file}}"
+            onerror={{imgOnError}}
+          />
         </div>
 
         <div class="p-a300 t--sans">

diff --git a/components/icons/drupal_icons/drupal_icons.config.yml b/components/icons/drupal_icons/drupal_icons.config.yml
@@ -2,6 +2,7 @@ title: "drupal icons"
 handle: "drupal_icons"
 status: "ready"
 context:
+  defaultIcon: "https://www.boston.gov/modules/custom/bos_content/modules/node_post/default_news.svg"
   icons:
     - file: "archive.svg"
     - file: "delete.svg"

diff --git a/components/icons/drupal_icons/drupal_icons.hbs b/components/icons/drupal_icons/drupal_icons.hbs
@@ -7,7 +7,12 @@
         </div>
 
         <div class="ex ex-i">
-          <img src="{{imgUrl "https://assets.boston.gov/icons/drupal_icons" icon.file}}" />
+          <img
+            alt="{{filename_to_string icon.file}}"
+            title="{{filename_to_string icon.file}}"
+            src="{{imgUrl "https://assets.boston.gov/icons/drupal_icons" icon.file}}"
+            onerror={{imgOnError}}
+          />
         </div>
 
         <div class="p-a300 t--sans">

diff --git a/components/icons/experiential_icons/experiential_icons.config.yml b/components/icons/experiential_icons/experiential_icons.config.yml
@@ -2,6 +2,7 @@ title: "experiential icons"
 handle: "experiential_icons"
 status: "ready"
 context:
+  defaultIcon: "https://www.boston.gov/modules/custom/bos_content/modules/node_post/default_news.svg"
   icons:
     - file: "1095_c_form.svg"
     - file: "1095_c_form_computer.svg"

diff --git a/components/icons/experiential_icons/experiential_icons.hbs b/components/icons/experiential_icons/experiential_icons.hbs
@@ -7,7 +7,12 @@
         </div>
 
         <div class="ex ex-i">
-          <img src="{{imgUrl "https://assets.boston.gov/icons/experiential_icons" icon.file}}" />
+          <img
+            alt="{{filename_to_string icon.file}}"
+            title="{{filename_to_string icon.file}}"
+            src="{{imgUrl "https://assets.boston.gov/icons/experiential_icons" icon.file}}"
+            onerror={{imgOnError}}
+          />
         </div>
 
         <div class="p-a300 t--sans">

diff --git a/components/icons/metrolist/metrolist.config.yml b/components/icons/metrolist/metrolist.config.yml
@@ -2,6 +2,7 @@ title: "metrolist"
 handle: "metrolist"
 status: "ready"
 context:
+  defaultIcon: "https://www.boston.gov/modules/custom/bos_content/modules/node_post/default_news.svg"
   icons:
     - file: "deposit_check.png"
     - file: "deposit_check.svg"

diff --git a/components/icons/metrolist/metrolist.hbs b/components/icons/metrolist/metrolist.hbs
@@ -7,7 +7,12 @@
         </div>
 
         <div class="ex ex-i">
-          <img src="{{imgUrl "https://assets.boston.gov/icons/metrolist" icon.file}}" />
+          <img
+            alt="{{filename_to_string icon.file}}"
+            title="{{filename_to_string icon.file}}"
+            src="{{imgUrl "https://assets.boston.gov/icons/metrolist" icon.file}}"
+            onerror={{imgOnError}}
+          />
         </div>
 
         <div class="p-a300 t--sans">

diff --git a/dev-scripts/icons_manifest/index.js b/dev-scripts/icons_manifest/index.js
@@ -48,6 +48,8 @@ const constructManifestYamlReadyObj = async icons => {
         handle: obj.category.replace(/ /g, '_'),
         status: 'ready',
         context: {
+          defaultIcon:
+            'https://www.boston.gov/modules/custom/bos_content/modules/node_post/default_news.svg',
           icons: [],
         },
       };

diff --git a/dev-scripts/icons_manifest/manifest.hbs b/dev-scripts/icons_manifest/manifest.hbs
@@ -7,7 +7,12 @@
         </div>
 
         <div class="ex ex-i">
-          <img src="{{imgUrl "https://assets.boston.gov/icons/directory_name" icon.file}}" />
+          <img
+            alt="{{filename_to_string icon.file}}"
+            title="{{filename_to_string icon.file}}"
+            src="{{imgUrl "https://assets.boston.gov/icons/directory_name" icon.file}}"
+            onerror={{imgOnError}}
+          />
         </div>
 
         <div class="p-a300 t--sans">

diff --git a/fractal.config.js b/fractal.config.js
@@ -73,6 +73,11 @@ const hbs = require('@frctl/handlebars')({
     imgUrl: async function(pre, post) {
       return `${pre}/${post}`;
     },
+    imgOnError: function() {
+      const url =
+        'https://www.boston.gov/modules/custom/bos_content/modules/node_post/default_news.svg';
+      return `this.onerror=null;this.src='${url}';`;
+    },
     // Stencil helps us maintain docs in the source directories for the
     // components. This helper is here so that the Fractal component "Notes" can
     // import those README files so that they appear in the Fractal UI.