This repository has been archived by the owner on Sep 12, 2023. It is now read-only.
Updates to map component #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a readme file
* removes lastupdated prop from div * use count method instead of length of id list for feature counts * use mapbox gl instead of leaflet for performance
* removes lastupdated prop from div * use count method instead of length of id list for feature counts * use mapbox gl instead of leaflet for performance * clean up leaflet artifacts * make feature service urls cleaner
* removes lastupdated prop from div * use count method instead of length of id list for feature counts * use mapbox gl instead of leaflet for performance * clean up leaflet artifacts * make feature service urls cleaner * deals with time zones for feauture counts
…into update-map
fionawhim
reviewed
Jul 31, 2018
| const mapboxgl = process.browser ? require('mapbox-gl') : null; | ||
| // Despite using mapboxgl to render the map, we still use esri-leaflet to | ||
| // query to the layer | ||
| const { featureLayer } = process.browser ? require('esri-leaflet') : {}; |
There was a problem hiding this comment.
Add a TODO to remove that dependency and just AJAX the info in.
There was a problem hiding this comment.
added here: #25. Could be a good debt bash item for next week
| 'cob-basemap': { | ||
| type: 'raster', | ||
| tiles: [ | ||
| 'https://awsgeo.boston.gov/arcgis/rest/services/Basemaps/BostonCityBasemap_WM/MapServer/tile/{z}/{y}/{x}', |
| this.map.on('click', e => { | ||
| // Crash and fatalitiy points are often stacked on top of eachother | ||
| // in the data. We want the pop-ups to show information about all | ||
| // the crashes that occured in the clicked location. |
components/Map.js
Outdated
| return a[1] > b[1] ? -1 : 1; | ||
| }); | ||
|
|
||
| new mapboxgl.Popup({ closeOnClickboolean: true }) |
There was a problem hiding this comment.
Should this just be closeOnClick: true?
There was a problem hiding this comment.
lol yes - thank you
paylakatel
added a commit
that referenced
this pull request
Jul 31, 2018
* fix icon url (#14) * adds back feature counts (#16) * Add a readme (#17) Adds a readme file * Update map (#20) * removes lastupdated prop from div * use count method instead of length of id list for feature counts * use mapbox gl instead of leaflet for performance * Update map (#21) * removes lastupdated prop from div * use count method instead of length of id list for feature counts * use mapbox gl instead of leaflet for performance * clean up leaflet artifacts * make feature service urls cleaner * Update map (#22) * removes lastupdated prop from div * use count method instead of length of id list for feature counts * use mapbox gl instead of leaflet for performance * clean up leaflet artifacts * make feature service urls cleaner * deals with time zones for feauture counts * Update map (#23) * removes lastupdated prop from div * use count method instead of length of id list for feature counts * use mapbox gl instead of leaflet for performance * clean up leaflet artifacts * make feature service urls cleaner * deals with time zones for feauture counts * adjust heatmap props, popups show num crashes and info about each * Updates to map component (#24) * fix icon url (#14) (#15) * adds back feature counts (#16) * Add a readme (#17) Adds a readme file * removes lastupdated prop from div * use count method instead of length of id list for feature counts * use mapbox gl instead of leaflet for performance * Update map (#20) * removes lastupdated prop from div * use count method instead of length of id list for feature counts * use mapbox gl instead of leaflet for performance * clean up leaflet artifacts * make feature service urls cleaner * Update map (#21) * removes lastupdated prop from div * use count method instead of length of id list for feature counts * use mapbox gl instead of leaflet for performance * clean up leaflet artifacts * make feature service urls cleaner * deals with time zones for feauture counts * Update map (#22) * removes lastupdated prop from div * use count method instead of length of id list for feature counts * use mapbox gl instead of leaflet for performance * clean up leaflet artifacts * make feature service urls cleaner * deals with time zones for feauture counts * adjust heatmap props, popups show num crashes and info about each * clean up code * fixed a couple typos in comments * fix closeOnClick typo * deleting extra lines/fixing what i broke (#28)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: